From 2d7d57238b6acc8ef2fe2d592a333a216e547693 Mon Sep 17 00:00:00 2001 From: dragon <66683631+dragon7307@users.noreply.github.com> Date: Tue, 3 Sep 2024 14:50:33 +0200 Subject: [PATCH 1/4] fixed release-notes.md donwload with curl. --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 58d3d07..392f778 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -48,7 +48,7 @@ jobs: - name: Store Environment Variable run: echo "VERSION=v${{ steps.extract_version.outputs.info }}" >> $GITHUB_ENV - name: Download release notes - run: curl -o release-notes.md https://drive.google.com/uc?export=download&id=1LdP8rvPZ9ra4mc4vmv3smcDwVD96Zwn8 + run: curl -o release-notes.md "https://drive.google.com/uc?export=download&id=1LdP8rvPZ9ra4mc4vmv3smcDwVD96Zwn8" -L - name: Create Tag run: | git config --global user.name "github-actions[bot]" From 094948fd24720a841289b2bd8ea5601f76dac827 Mon Sep 17 00:00:00 2001 From: dragon7307 Date: Wed, 4 Sep 2024 11:04:24 +0200 Subject: [PATCH 2/4] excluded Replace() and Count() for Versions later or equal to net8.0 to avoid conflicts with methods present in these versions --- src/Extensions/ReadOnlySpan/Linq/Count.cs | 4 +++- src/Extensions/Span/Linq/Count.cs | 3 ++- src/Extensions/Span/String/Replace.cs | 7 +++++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/Extensions/ReadOnlySpan/Linq/Count.cs b/src/Extensions/ReadOnlySpan/Linq/Count.cs index 175110a..dd8993b 100644 --- a/src/Extensions/ReadOnlySpan/Linq/Count.cs +++ b/src/Extensions/ReadOnlySpan/Linq/Count.cs @@ -4,6 +4,8 @@ namespace SpanExtensions { public static partial class ReadOnlySpanExtensions { +#if !NET8_0_OR_GREATER // support for this method has been added in .Net 8. Just include it for backward-compatibility. + /// /// Returns the number of elements in a . /// @@ -15,7 +17,7 @@ public static int Count(this ReadOnlySpan source) { return source.Length; } - +#endif /// /// Returns a number that represents how many elements in the specified sequence satisfy a condition. /// diff --git a/src/Extensions/Span/Linq/Count.cs b/src/Extensions/Span/Linq/Count.cs index 34cf62d..194d3d0 100644 --- a/src/Extensions/Span/Linq/Count.cs +++ b/src/Extensions/Span/Linq/Count.cs @@ -4,6 +4,7 @@ namespace SpanExtensions { public static partial class SpanExtensions { +#if !NET8_0_OR_GREATER // support for this method has been added in .Net 8. Just include it for backward-compatibility. /// /// Returns the number of elements in a . /// @@ -15,7 +16,7 @@ public static int Count(this Span source) { return ReadOnlySpanExtensions.Count(source); } - +#endif /// /// Returns a number that represents how many elements in the specified sequence satisfy a condition. /// diff --git a/src/Extensions/Span/String/Replace.cs b/src/Extensions/Span/String/Replace.cs index d0922f6..26a7390 100644 --- a/src/Extensions/Span/String/Replace.cs +++ b/src/Extensions/Span/String/Replace.cs @@ -1,4 +1,6 @@ -using System; +#if !NET8_0_OR_GREATER // support for this method has been added in .Net 8. Just include it for backward-compatibility. + +using System; namespace SpanExtensions { @@ -22,4 +24,5 @@ public static void Replace(this Span source, T oldT, T newT) where T : IEq } } } -} \ No newline at end of file +} +#endif \ No newline at end of file From 7fc205aa1c5b2a050ab58728a643028a9996f089 Mon Sep 17 00:00:00 2001 From: dragon7307 Date: Mon, 9 Sep 2024 16:03:20 +0200 Subject: [PATCH 3/4] readded Count to .Net 8. --- src/Extensions/ReadOnlySpan/Linq/Count.cs | 4 +--- src/Extensions/Span/Linq/Count.cs | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Extensions/ReadOnlySpan/Linq/Count.cs b/src/Extensions/ReadOnlySpan/Linq/Count.cs index dd8993b..175110a 100644 --- a/src/Extensions/ReadOnlySpan/Linq/Count.cs +++ b/src/Extensions/ReadOnlySpan/Linq/Count.cs @@ -4,8 +4,6 @@ namespace SpanExtensions { public static partial class ReadOnlySpanExtensions { -#if !NET8_0_OR_GREATER // support for this method has been added in .Net 8. Just include it for backward-compatibility. - /// /// Returns the number of elements in a . /// @@ -17,7 +15,7 @@ public static int Count(this ReadOnlySpan source) { return source.Length; } -#endif + /// /// Returns a number that represents how many elements in the specified sequence satisfy a condition. /// diff --git a/src/Extensions/Span/Linq/Count.cs b/src/Extensions/Span/Linq/Count.cs index 194d3d0..34cf62d 100644 --- a/src/Extensions/Span/Linq/Count.cs +++ b/src/Extensions/Span/Linq/Count.cs @@ -4,7 +4,6 @@ namespace SpanExtensions { public static partial class SpanExtensions { -#if !NET8_0_OR_GREATER // support for this method has been added in .Net 8. Just include it for backward-compatibility. /// /// Returns the number of elements in a . /// @@ -16,7 +15,7 @@ public static int Count(this Span source) { return ReadOnlySpanExtensions.Count(source); } -#endif + /// /// Returns a number that represents how many elements in the specified sequence satisfy a condition. /// From e6b8c238dbad8bf124cf4dcb6d2dd9d022a8db8b Mon Sep 17 00:00:00 2001 From: dragon7307 Date: Mon, 9 Sep 2024 16:05:43 +0200 Subject: [PATCH 4/4] bumped version --- src/SpanExtensions.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SpanExtensions.csproj b/src/SpanExtensions.csproj index 8d56c48..323fd81 100644 --- a/src/SpanExtensions.csproj +++ b/src/SpanExtensions.csproj @@ -22,7 +22,7 @@ Span;Performance;Extension;String https://github.com/draconware-dev/SpanExtensions.Net/blob/main/Changelog.md LICENSE - 1.4 + 1.4.1 SpanExtensions.Net README.md icon.png