Skip to content

fix redis distributed lock for different process #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix redis distributed lock for different process #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c023e67
fix redis distributed lock for different process
DisenkoArt Jan 19, 2023
5b261b1
change LockRelease to LockReleaseAsync
DisenkoArt Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions src/EasyCaching.Redis/DistributedLock/RedisLockProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,19 @@ public class RedisLockProvider : IDistributedLockProvider
public RedisLockProvider(IDatabase database) => _database = database;

public Task<bool> SetAsync(string key, byte[] value, int ttlMs) =>
_database.StringSetAsync(key, value, TimeSpan.FromMilliseconds(ttlMs));
_database.StringSetAsync((RedisKey)key, (RedisValue)value, TimeSpan.FromMilliseconds(ttlMs));

public bool Add(string key, byte[] value, int ttlMs) =>
_database.StringSet(key, value, TimeSpan.FromMilliseconds(ttlMs));
_database.LockTake((RedisKey)key, (RedisValue)value, TimeSpan.FromMilliseconds(ttlMs));

public Task<bool> AddAsync(string key, byte[] value, int ttlMs) =>
_database.StringSetAsync(key, value, TimeSpan.FromMilliseconds(ttlMs));
_database.LockTakeAsync((RedisKey)key, (RedisValue)value, TimeSpan.FromMilliseconds(ttlMs));

public bool Delete(string key, byte[] value) =>
(long)_database.ScriptEvaluate(@"if redis.call('GET', KEYS[1]) == ARGV[1] then
return redis.call('DEL', KEYS[1]);
end
return -1;", new RedisKey[] { key }, new RedisValue[] { value }) >= 0;
public bool Delete(string key, byte[] value) => _database.LockRelease((RedisKey)key, (RedisValue)value);

public async Task<bool> DeleteAsync(string key, byte[] value) =>
(long)await _database.ScriptEvaluateAsync(@"if redis.call('GET', KEYS[1]) == ARGV[1] then
return redis.call('DEL', KEYS[1]);
end
return -1;", new RedisKey[] { key }, new RedisValue[] { value }) >= 0;
public Task<bool> DeleteAsync(string key, byte[] value) =>
_database.LockReleaseAsync((RedisKey)key, (RedisValue)value);

public bool CanRetry(Exception ex) => ex is RedisConnectionException;
}
}
}