Remove RunClassConstructor proxy from SecurityHelper for code quality #9893
+22
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Contributor
|
LGTM |
siagupta0202
approved these changes
Oct 10, 2024
harshit7962
added
Included in test pass
Status:Committed
Status:InProgress
and removed
Queue for test pass
labels
Member
|
@h3xds1nz Thank you for your contributions. |
Member
Author
|
@harshit7962 Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the few leftover remnants from CAS times is the
SecurityHelper.RunClassConstructorthe RunClassConstructor method fromRuntimeHelpers. There is no reason for this, only makes people wonder what is "security" doing here.Follows PRs like #9521, #9733 etc.
Customer Impact
Better code quality of the code base.
Regression
No.
Testing
Local build.
Risk
Pretty much none.
Microsoft Reviewers: Open in CodeFlow