Add test coverage for public API surface of BrushConverter #10632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Member
Author
|
The CI failure is caused by the missing dependency as I've discussed in #10623 (and provided fix for in that PR) |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10632 +/- ##
===================================================
+ Coverage 11.22814% 11.50597% +0.27782%
===================================================
Files 3352 3354 +2
Lines 668000 668253 +253
Branches 74980 74981 +1
===================================================
+ Hits 75004 76889 +1885
+ Misses 591745 589968 -1777
- Partials 1251 1396 +145
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dipeshmsft
approved these changes
Apr 4, 2025
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds test coverage for
BrushConverter. Sending these to support the #10225 PR.This doesn't add
ConvertTo/ITypeDescriptorContexttests (as they're not relevant for the PR), should be added later.Customer Impact
Improved test coverage on public API surface.
Regression
No.
Testing
Local build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow