Skip to content

Conversation

@laneser
Copy link
Contributor

@laneser laneser commented Jun 21, 2020

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @laneser! (and thanks @suhsteve for review)

@imback82 imback82 merged commit 3701d2e into dotnet:master Jun 21, 2020
@imback82
Copy link
Contributor

@laneser Do you want to help fixing the link in https://github.com/dotnet/spark/blob/master/docs/building/windows-instructions.md as well?

laneser added a commit to bridgewell/spark that referenced this pull request Jun 22, 2020
Fix broken maven link in building/ubuntu-instructions.md (dotnet#558)
@laneser laneser deleted the feature/FixUbuntuBuildLink branch June 24, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants