Skip to content

Commit c31a03e

Browse files
omajidcrummel
authored andcommitted
Enable building on arm64 (#1300)
* Enable building on arm64 This change allows source-build to be cloned and built on arm64 machines. It shouldn't affect cross compilation at all, however. I have tested this on RHEL 8 aarch64. This change includes backports of the following pull-requests which have been merged into their respective master branches: - dotnet/aspnetcore#14790 - dotnet/aspnetcore#15354 - dotnet/installer#4102 - dotnet/core-setup#8468 - dotnet/corefx#40453 There's a number of existing build configuration that are conditionalized on arm64, such as setting up a root file system. Those they are actually only meant to be invoked when cross-compiling for arm64 (on x86_64). This commit modifies those conditions to not apply when building on an arm64 machine. * Patch fixup.
1 parent e78695f commit c31a03e

25 files changed

+493
-108
lines changed

build-source-tarball.sh

Lines changed: 42 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,32 @@ if [ -z "${1:-}" ]; then
1212
exit 1
1313
fi
1414

15+
# Use uname to determine what the CPU is.
16+
cpuname=$(uname -p)
17+
# Some Linux platforms report unknown for platform, but the arch for machine.
18+
if [[ "$cpuname" == "unknown" ]]; then
19+
cpuname=$(uname -m)
20+
fi
21+
22+
case $cpuname in
23+
aarch64)
24+
targetArchitecture=arm64
25+
;;
26+
amd64|x86_64)
27+
targetArchitecture=x64
28+
;;
29+
armv7l)
30+
targetArchitecture=arm
31+
;;
32+
i686)
33+
targetArchitecture=x86
34+
;;
35+
*)
36+
echo "Unknown CPU $cpuname detected, treating it as x64"
37+
targetArchitecture=x64
38+
;;
39+
esac
40+
1541
TARBALL_ROOT=$1
1642
shift
1743

@@ -217,28 +243,28 @@ cp $SCRIPT_ROOT/support/tarball/build.sh $TARBALL_ROOT/build.sh
217243
mkdir -p $TARBALL_ROOT/packages/prebuilt
218244
mkdir -p $TARBALL_ROOT/packages/source-built
219245
find $SCRIPT_ROOT/packages/restored/ -name '*.nupkg' -exec cp {} $TARBALL_ROOT/packages/prebuilt/ \;
220-
find $SCRIPT_ROOT/bin/obj/x64/Release/nuget-packages -name '*.nupkg' -exec cp {} $TARBALL_ROOT/packages/prebuilt/ \;
246+
find $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/nuget-packages -name '*.nupkg' -exec cp {} $TARBALL_ROOT/packages/prebuilt/ \;
221247

222248
# Copy reference-packages from bin dir to reference-packages directory.
223249
# See corresponding change in dir.props to change ReferencePackagesBasePath conditionally in offline build.
224250
mkdir -p $TARBALL_ROOT/packages/reference
225-
cp -r $SCRIPT_ROOT/bin/obj/x64/Release/reference-packages/source $TARBALL_ROOT/packages/reference/source
226-
cp -r $SCRIPT_ROOT/bin/obj/x64/Release/reference-packages/staging $TARBALL_ROOT/packages/reference/staging
251+
cp -r $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/reference-packages/source $TARBALL_ROOT/packages/reference/source
252+
cp -r $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/reference-packages/staging $TARBALL_ROOT/packages/reference/staging
227253

228254
# Copy tarballs to ./packages/archive directory
229255
mkdir -p $TARBALL_ROOT/packages/archive
230-
cp -r $SCRIPT_ROOT/bin/obj/x64/Release/external-tarballs/*.tar.gz $TARBALL_ROOT/packages/archive/
256+
cp -r $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/external-tarballs/*.tar.gz $TARBALL_ROOT/packages/archive/
231257

232258
# Copy generated source from bin to src/generatedSrc
233-
cp -r $SCRIPT_ROOT/bin/obj/x64/Release/generatedSrc $TARBALL_ROOT/src/generatedSrc
259+
cp -r $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/generatedSrc $TARBALL_ROOT/src/generatedSrc
234260

235261
if [ -e $SCRIPT_ROOT/testing-smoke/smoke-test-packages ]; then
236262
cp -rf $SCRIPT_ROOT/testing-smoke/smoke-test-packages $TARBALL_ROOT/packages
237263
fi
238264

239265
echo 'Removing source-built packages from tarball prebuilts...'
240266

241-
for built_package in $(find $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/ -name '*.nupkg' | tr '[:upper:]' '[:lower:]')
267+
for built_package in $(find $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/ -name '*.nupkg' | tr '[:upper:]' '[:lower:]')
242268
do
243269
if [ -e $TARBALL_ROOT/packages/prebuilt/$(basename $built_package) ]; then
244270
rm $TARBALL_ROOT/packages/prebuilt/$(basename $built_package)
@@ -251,16 +277,16 @@ done
251277
echo 'Copying source-built packages to tarball to replace packages needed before they are built...'
252278
mkdir -p $TARBALL_ROOT/packages/source-built
253279
cp -r $SCRIPT_ROOT/Tools/source-built/coreclr-tools $TARBALL_ROOT/packages/source-built/
254-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*Arcade*.nupkg $TARBALL_ROOT/packages/source-built/
255-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*SourceLink*.nupkg $TARBALL_ROOT/packages/source-built/
256-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*Build*Tasks*.nupkg $TARBALL_ROOT/packages/source-built/
257-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/runtime*.nupkg $TARBALL_ROOT/packages/source-built/
258-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*DotNetHost*.nupkg $TARBALL_ROOT/packages/source-built/
259-
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*DotNetAppHost*.nupkg $TARBALL_ROOT/packages/source-built/
280+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*Arcade*.nupkg $TARBALL_ROOT/packages/source-built/
281+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*SourceLink*.nupkg $TARBALL_ROOT/packages/source-built/
282+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*Build*Tasks*.nupkg $TARBALL_ROOT/packages/source-built/
283+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/runtime*.nupkg $TARBALL_ROOT/packages/source-built/
284+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*DotNetHost*.nupkg $TARBALL_ROOT/packages/source-built/
285+
cp $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*DotNetAppHost*.nupkg $TARBALL_ROOT/packages/source-built/
260286

261287
# Setup package version props to include both source-built and running PackageVersions.props
262-
mkdir --parents $TARBALL_ROOT/bin/obj/x64/Release/
263-
cp $SCRIPT_ROOT/support/tarball/PackageVersions.props $TARBALL_ROOT/bin/obj/x64/Release/
288+
mkdir --parents $TARBALL_ROOT/bin/obj/$targetArchitecture/Release/
289+
cp $SCRIPT_ROOT/support/tarball/PackageVersions.props $TARBALL_ROOT/bin/obj/$targetArchitecture/Release/
264290

265291
if [ $INCLUDE_LEAK_DETECTION -eq 1 ]; then
266292
echo 'Building leak detection MSBuild tasks...'
@@ -270,7 +296,7 @@ fi
270296

271297
echo 'Removing reference-only packages from tarball prebuilts...'
272298

273-
for ref_package in $(find $SCRIPT_ROOT/bin/obj/x64/Release/reference-packages/packages-to-delete/ -name '*.nupkg' | tr '[:upper:]' '[:lower:]')
299+
for ref_package in $(find $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/reference-packages/packages-to-delete/ -name '*.nupkg' | tr '[:upper:]' '[:lower:]')
274300
do
275301
if [ -e $TARBALL_ROOT/packages/prebuilt/$(basename $ref_package) ]; then
276302
rm $TARBALL_ROOT/packages/prebuilt/$(basename $ref_package)
@@ -328,7 +354,7 @@ fi
328354
echo 'Removing source-built, previously source-built packages and reference packages from il pkg src...'
329355
OLDIFS=$IFS
330356

331-
allBuiltPkgs=(`ls $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*.nupkg | xargs -n1 basename | tr '[:upper:]' '[:lower:]'`)
357+
allBuiltPkgs=(`ls $SCRIPT_ROOT/bin/obj/$targetArchitecture/Release/blob-feed/packages/*.nupkg | xargs -n1 basename | tr '[:upper:]' '[:lower:]'`)
332358
pushd $TARBALL_ROOT/packages/reference/staging/
333359
ilSrcPaths=(`find . -maxdepth 2 -mindepth 2`)
334360
popd

dir.props

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<PropertyGroup>
44
<Configuration Condition="$(Configuration) == ''">Release</Configuration>
5+
6+
<BuildArchitecture>$([System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture.ToString().ToLowerInvariant())</BuildArchitecture>
7+
<Platform Condition="'$(Platform)' == '' AND '$(BuildArchitecture)' == 'arm64'">$(BuildArchitecture)</Platform>
58
<Platform Condition="'$(Platform)' == ''">x64</Platform>
69

710
<!-- true if we have bootstrapped buildtools (usually on an unsupported platform -->
@@ -201,7 +204,7 @@
201204
<ExtraPackageVersionPropsPackageInfo Include="MicrosoftNETCoreAppRuntimePackageVersion" Version="%24(MicrosoftNETCoreDotNetAppHostPackageVersion)" />
202205
<ExtraPackageVersionPropsPackageInfo Include="MicrosoftNETCoreAppRuntimeVersion" Version="%24(MicrosoftNETCoreDotNetAppHostPackageVersion)" />
203206
<ExtraPackageVersionPropsPackageInfo Include="MicrosoftNETCoreAppHostPackageVersion" Version="%24(MicrosoftNETCoreDotNetAppHostPackageVersion)" />
204-
<ExtraPackageVersionPropsPackageInfo Include="MicrosoftAspNetCoreAppRuntimePackageVersion" Version="%24(MicrosoftAspNetCoreAppRuntimeLinuxX64PackageVersion)" />
207+
<ExtraPackageVersionPropsPackageInfo Include="MicrosoftAspNetCoreAppRuntimePackageVersion" Version="%24(MicrosoftAspNetCoreAppRuntimeLinux$(Platform)PackageVersion)" />
205208
<!-- core-sdk uses this property for ASP.NET blob directory -->
206209
<ExtraPackageVersionPropsPackageInfo Include="VSRedistCommonAspNetCoreTargetingPackx6430PackageVersion" Version="$(aspnetcoreOutputPackageVersion)" />
207210
<!-- OSX needs the OSX version instead of Linux. We don't have a lot of flexibility in how we output these properties so we're relying on the previous one being blank if the Linux version of the package is missing. -->

patches/aspnetcore/0001-Don-t-call-dotnet-without-path.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
From b7a4992bfa45d3b1c00e095b0b1e7d860b347b50 Mon Sep 17 00:00:00 2001
1+
From c9ceade354813f98ca291757e7d1657d0959ee4e Mon Sep 17 00:00:00 2001
22
From: Chris Rummel <[email protected]>
33
Date: Wed, 23 Oct 2019 20:04:55 -0500
4-
Subject: [PATCH 01/10] Don't call dotnet without path
4+
Subject: [PATCH 01/13] Don't call dotnet without path
55

66
---
77
eng/common/tools.sh | 6 +++---
88
1 file changed, 3 insertions(+), 3 deletions(-)
99

1010
diff --git a/eng/common/tools.sh b/eng/common/tools.sh
11-
index 757d5b9..5a4cfeb 100755
11+
index 757d5b9ea4..5a4cfeb1f0 100755
1212
--- a/eng/common/tools.sh
1313
+++ b/eng/common/tools.sh
1414
@@ -340,9 +340,9 @@ function MSBuild {
@@ -25,5 +25,5 @@ index 757d5b9..5a4cfeb 100755
2525
local toolset_dir="${_InitializeToolset%/*}"
2626
local logger_path="$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.Arcade.Sdk.dll"
2727
--
28-
1.8.3.1
28+
2.18.0
2929

patches/aspnetcore/0002-Use-non-portable-NETCoreAppRuntime-for-crossgen.patch

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
From bec8be99172078645255a96cc012a1d2a95da8df Mon Sep 17 00:00:00 2001
1+
From 528f9457371651668d1923b27cdd5b761f8f2441 Mon Sep 17 00:00:00 2001
22
From: dseefeld <[email protected]>
33
Date: Tue, 29 Oct 2019 18:19:03 +0000
4-
Subject: [PATCH 02/10] Use non-portable NETCoreAppRuntime for crossgen
4+
Subject: [PATCH 02/13] Use non-portable NETCoreAppRuntime for crossgen
55

66
---
77
eng/Dependencies.props | 1 +
88
src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj | 6 ++++--
99
2 files changed, 5 insertions(+), 2 deletions(-)
1010

1111
diff --git a/eng/Dependencies.props b/eng/Dependencies.props
12-
index 2e11857..b49aee2 100644
12+
index 2e11857b1b..b49aee2a5c 100644
1313
--- a/eng/Dependencies.props
1414
+++ b/eng/Dependencies.props
1515
@@ -110,6 +110,7 @@ and are generated based on the last package release.
@@ -21,7 +21,7 @@ index 2e11857..b49aee2 100644
2121

2222
<ItemGroup Label=".NET team dependencies (Non-source-build)" Condition="'$(DotNetBuildFromSource)' != 'true'">
2323
diff --git a/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj
24-
index 4c4298a..edad46b 100644
24+
index 4c4298a92d..edad46be14 100644
2525
--- a/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj
2626
+++ b/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj
2727
@@ -100,7 +100,9 @@ This package is an internal implementation of the .NET Core SDK and is not meant
@@ -45,5 +45,5 @@ index 4c4298a..edad46b 100644
4545
<ProjectReference Condition="'$(BuildIisNativeProjects)' == 'true' AND '$(BuildNative)' != 'false' AND '$(VCTargetsPath)' != ''" Include="$(RepoRoot)src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj">
4646
<SetPlatform>Platform=$(TargetArchitecture)</SetPlatform>
4747
--
48-
1.8.3.1
48+
2.18.0
4949

patches/aspnetcore/0003-Conditionally-set-PackAsToolShimRID.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
From f7b62cf3e579babe120deb06be418541c717388c Mon Sep 17 00:00:00 2001
1+
From 87371172f24562810552567b15890eefc9d57249 Mon Sep 17 00:00:00 2001
22
From: dseefeld <[email protected]>
33
Date: Thu, 31 Oct 2019 20:38:26 +0000
4-
Subject: [PATCH 03/10] Conditionally set PackAsToolShimRID
4+
Subject: [PATCH 03/13] Conditionally set PackAsToolShimRID
55

66
---
77
Directory.Build.targets | 2 +-
88
1 file changed, 1 insertion(+), 1 deletion(-)
99

1010
diff --git a/Directory.Build.targets b/Directory.Build.targets
11-
index db3cea5..518b5e6 100644
11+
index db3cea59f1..518b5e6246 100644
1212
--- a/Directory.Build.targets
1313
+++ b/Directory.Build.targets
1414
@@ -46,7 +46,7 @@
@@ -21,5 +21,5 @@ index db3cea5..518b5e6 100644
2121
<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86</PackAsToolShimRuntimeIdentifiers>
2222
</PropertyGroup>
2323
--
24-
1.8.3.1
24+
2.18.0
2525

patches/aspnetcore/0004-Exclude-analyzer-for-source-build.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
From ff7c8a971e21f847db4a9f762c6232a859aebbd1 Mon Sep 17 00:00:00 2001
1+
From bbd6cbebda9e08a49725b66d9130f76469479413 Mon Sep 17 00:00:00 2001
22
From: adaggarwal <[email protected]>
33
Date: Thu, 14 Nov 2019 16:52:25 +0000
4-
Subject: [PATCH 04/10] Exclude analyzer for source-build
4+
Subject: [PATCH 04/13] Exclude analyzer for source-build
55

66
---
77
Directory.Build.props | 2 +-
88
1 file changed, 1 insertion(+), 1 deletion(-)
99

1010
diff --git a/Directory.Build.props b/Directory.Build.props
11-
index 2fe19bd..0bc8b25 100644
11+
index 2fe19bde83..0bc8b25ecc 100644
1212
--- a/Directory.Build.props
1313
+++ b/Directory.Build.props
1414
@@ -95,7 +95,7 @@
@@ -21,5 +21,5 @@ index 2fe19bd..0bc8b25 100644
2121
</ItemGroup>
2222

2323
--
24-
1.8.3.1
24+
2.18.0
2525

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
From 938dad01514f3a4d7bf8f5c8b976cee3d43cdae0 Mon Sep 17 00:00:00 2001
1+
From 2812263dd785904cf8edd68f258d78d82c3cea59 Mon Sep 17 00:00:00 2001
22
From: adaggarwal <[email protected]>
33
Date: Thu, 14 Nov 2019 16:55:29 +0000
4-
Subject: [PATCH 05/10] Import PackageVersions.props
4+
Subject: [PATCH 05/13] Import PackageVersions.props
55

66
---
77
eng/Versions.props | 3 +++
88
1 file changed, 3 insertions(+)
99

1010
diff --git a/eng/Versions.props b/eng/Versions.props
11-
index fd988d1..71384d1 100644
11+
index a3e611aa4b..37797a5219 100644
1212
--- a/eng/Versions.props
1313
+++ b/eng/Versions.props
14-
@@ -264,6 +264,9 @@
14+
@@ -267,6 +267,9 @@
1515
<XunitExtensibilityExecutionPackageVersion>$(XunitVersion)</XunitExtensibilityExecutionPackageVersion>
1616
<MicrosoftDataSqlClientPackageVersion>1.0.19249.1</MicrosoftDataSqlClientPackageVersion>
1717
</PropertyGroup>
@@ -22,5 +22,5 @@ index fd988d1..71384d1 100644
2222
<PropertyGroup Label="Restore feeds">
2323
<!-- In an orchestrated build, this may be overridden to other Azure feeds. -->
2424
--
25-
1.8.3.1
25+
2.18.0
2626

patches/aspnetcore/0006-Exclude-some-projects-from-source-build.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
From 8de8ac124fdc61fef00c21aa9f4e03e1eeaa46f1 Mon Sep 17 00:00:00 2001
1+
From 494311a11525c9ca8ce44cff9d6de39802d1dbc6 Mon Sep 17 00:00:00 2001
22
From: adaggarwal <[email protected]>
33
Date: Thu, 14 Nov 2019 16:57:39 +0000
4-
Subject: [PATCH 06/10] Exclude some projects from source-build
4+
Subject: [PATCH 06/13] Exclude some projects from source-build
55

66
---
77
Directory.Build.props | 2 ++
88
1 file changed, 2 insertions(+)
99

1010
diff --git a/Directory.Build.props b/Directory.Build.props
11-
index 0bc8b25..88411a3 100644
11+
index 0bc8b25ecc..88411a30b2 100644
1212
--- a/Directory.Build.props
1313
+++ b/Directory.Build.props
1414
@@ -18,9 +18,11 @@
@@ -24,5 +24,5 @@ index 0bc8b25..88411a3 100644
2424
<!--
2525
Following logic mimics core-setup approach as well as
2626
--
27-
1.8.3.1
27+
2.18.0
2828

patches/aspnetcore/0007-Fix-version-number.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
From 68980720c56f0a0b6d85189e77e11937e22a2119 Mon Sep 17 00:00:00 2001
1+
From e4b686cfdeeb4d921b3c6e5a63283eff8672856e Mon Sep 17 00:00:00 2001
22
From: adaggarwal <[email protected]>
33
Date: Thu, 14 Nov 2019 17:27:30 +0000
4-
Subject: [PATCH 07/10] Fix version number
4+
Subject: [PATCH 07/13] Fix version number
55

66
---
7-
.../Web.JS/dist/Release/blazor.server.js | Bin 214579 -> 214584 bytes
7+
.../Web.JS/dist/Release/blazor.server.js | Bin 214579 -> 214584 bytes
88
1 file changed, 0 insertions(+), 0 deletions(-)
99

1010
diff --git a/src/Components/Web.JS/dist/Release/blazor.server.js b/src/Components/Web.JS/dist/Release/blazor.server.js
@@ -17,5 +17,5 @@ delta 24
1717
fcmdnd!@IeMx1oixg=q`3wi`!EYMD}Ptfn;pZdwQU
1818

1919
--
20-
1.8.3.1
20+
2.18.0
2121

patches/aspnetcore/0008-Remove-Yarn-dependency-not-used-in-source-build.patch

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
From 78a5ac365ba2f82bec480ebba724cf5d60966a91 Mon Sep 17 00:00:00 2001
1+
From a0ae7e9b334c167943035dff556730d017baa760 Mon Sep 17 00:00:00 2001
22
From: adaggarwal <[email protected]>
33
Date: Thu, 14 Nov 2019 17:34:41 +0000
4-
Subject: [PATCH 08/10] Remove Yarn dependency - not used in source-build
4+
Subject: [PATCH 08/13] Remove Yarn dependency - not used in source-build
55

66
---
7-
eng/targets/Npm.Common.targets | 3 ---
8-
global.json | 1 -
9-
.../NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj | 3 ---
10-
src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj | 3 ---
11-
src/Shared/E2ETesting/E2ETesting.targets | 3 ---
7+
eng/targets/Npm.Common.targets | 3 ---
8+
global.json | 1 -
9+
.../NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj | 3 ---
10+
.../SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj | 3 ---
11+
src/Shared/E2ETesting/E2ETesting.targets | 3 ---
1212
5 files changed, 13 deletions(-)
1313

1414
diff --git a/eng/targets/Npm.Common.targets b/eng/targets/Npm.Common.targets
15-
index 062a9d3..3f91b02 100644
15+
index 062a9d3a8f..3f91b02d42 100644
1616
--- a/eng/targets/Npm.Common.targets
1717
+++ b/eng/targets/Npm.Common.targets
1818
@@ -1,8 +1,5 @@
@@ -25,7 +25,7 @@ index 062a9d3..3f91b02 100644
2525
<NormalizedPackageId>$(PackageId.Replace('@','').Replace('/','-'))</NormalizedPackageId>
2626
<PackageFileName>$(NormalizedPackageId)-$(PackageVersion).tgz</PackageFileName>
2727
diff --git a/global.json b/global.json
28-
index 17454ad..2f5a03b 100644
28+
index 17454ad1bf..2f5a03b4b6 100644
2929
--- a/global.json
3030
+++ b/global.json
3131
@@ -24,7 +24,6 @@
@@ -37,7 +37,7 @@ index 17454ad..2f5a03b 100644
3737
"Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19517.3"
3838
}
3939
diff --git a/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj b/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj
40-
index e67862e..29c3b8c 100644
40+
index e67862ea45..29c3b8c137 100644
4141
--- a/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj
4242
+++ b/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj
4343
@@ -16,9 +16,6 @@
@@ -51,7 +51,7 @@ index e67862e..29c3b8c 100644
5151
<Message Text="Running yarn install on $(MSBuildProjectFile)" Importance="High" />
5252
<Yarn Command="install --mutex network" />
5353
diff --git a/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj b/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj
54-
index 3db479b..ad01493 100644
54+
index 3db479b01e..ad0149356f 100644
5555
--- a/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj
5656
+++ b/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj
5757
@@ -20,9 +20,6 @@
@@ -65,7 +65,7 @@ index 3db479b..ad01493 100644
6565
<Message Text="Running yarn install on $(MSBuildProjectFile)" Importance="High" />
6666
<Yarn Command="install --mutex network" />
6767
diff --git a/src/Shared/E2ETesting/E2ETesting.targets b/src/Shared/E2ETesting/E2ETesting.targets
68-
index 500d910..2ccf1a4 100644
68+
index 500d910a30..2ccf1a431c 100644
6969
--- a/src/Shared/E2ETesting/E2ETesting.targets
7070
+++ b/src/Shared/E2ETesting/E2ETesting.targets
7171
@@ -1,7 +1,4 @@
@@ -77,5 +77,5 @@ index 500d910..2ccf1a4 100644
7777
<ItemGroup>
7878
<None Update="e2eTestSettings*.json">
7979
--
80-
1.8.3.1
80+
2.18.0
8181

0 commit comments

Comments
 (0)