fix ordering so that getting Container config establishes RIDness #49590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the target dependency ordering to ensure container RIDness is correctly established before computing the container configuration. The changes remove the redundant _IsSingleRIDBuild property from tests and update target dependencies in the Microsoft.NET.Build.Containers.targets file.
- Removed the assignment of "_IsSingleRIDBuild" from test targets.
- Updated target dependencies by inserting _ContainerEstablishRIDNess in ComputeContainerConfig and related targets.
- Reordered the publish target dependencies to align with the new ordering requirement.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.NET.Build.Containers.IntegrationTests/TargetsTests.cs | Removed redundant property to reflect new dependency ordering. |
| src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets | Updated target dependencies to ensure proper ordering for establishing RIDness. |
github-actions
bot
added
the
Area-Containers
baronfel
force-pushed
the
fix-container-metadata-target-dependencies
branch
from
9b4dd38 to
f149378
Compare
rainersigwald
approved these changes
Jul 7, 2025
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
baronfel
force-pushed
the
fix-container-metadata-target-dependencies
branch
from
f149378 to
b9403e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49586 by making sure that the Target that sets the conditions for the execution args to be computed is called in every case where ComputeContainerConfig might be called standalone.