Merge pull request #2581 from dsplaisted/fix-aspnet-privateassets

Fix issue where ASP.NET PackageReferences with implicit versions had incorrect PrivateAssets value

Author: dsplaisted

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.targets

@@ -97,12 +97,12 @@ Copyright (c) .NET Foundation. All rights reserved.
   <ItemGroup>
     <!-- Set implicit metadata on ASP.NET package references -->
     <PackageReference Update="Microsoft.AspNetCore.App">
-      <PrivateAssets Condition="'%(PackageReference.Version)' == ''">true</PrivateAssets>
+      <PrivateAssets Condition="'%(PackageReference.Version)' == ''">all</PrivateAssets>
       <Publish Condition="'%(PackageReference.Version)' == ''">true</Publish>
     </PackageReference>
 
     <PackageReference Update="Microsoft.AspNetCore.All">
-      <PrivateAssets Condition="'%(PackageReference.Version)' == ''">true</PrivateAssets>
+      <PrivateAssets Condition="'%(PackageReference.Version)' == ''">all</PrivateAssets>
       <Publish Condition="'%(PackageReference.Version)' == ''">true</Publish>
     </PackageReference>
 

src/Tests/Microsoft.NET.Pack.Tests/GivenThatThereAreImplicitPackageReferences.cs

@@ -158,6 +158,27 @@ public void Packing_a_netcoreapp_2_0_app_does_not_include_the_implicit_dependenc
             dependencies.Should().BeEmpty();
         }
 
+        [Theory]
+        [InlineData("Microsoft.AspNetCore.App")]
+        [InlineData("Microsoft.AspNetCore.All")]
+        public void Package_an_aspnetcore_2_1_app_does_not_include_the_implicit_dependency(string packageId)
+        {
+            TestProject testProject = new TestProject()
+            {
+                Name = "PackAspNetCoreApp21App",
+                IsSdkProject = true,
+                TargetFrameworks = "netcoreapp2.1",
+                IsExe = true
+            };
+
+            testProject.PackageReferences.Add(new TestPackageReference(packageId, ""));
+
+            var dependencies = PackAndGetDependencies(testProject);
+
+            dependencies.Should().BeEmpty();
+
+        }
+
         [Fact]
         public void Packing_a_netcoreapp_2_0_DotnetCliTool_app_includes_the_implicit_dependency()
         {