Apply code review feedback

Author: dsplaisted

src/Tasks/Microsoft.NET.Build.Tasks/ApplyImplicitVersions.cs

@@ -31,15 +31,12 @@ protected override void ExecuteCore()
 
             var packageReferencesToUpdate = new List<ITaskItem>();
 
-            var implicitReferencesForThisFramework = ImplicitPackageReferenceVersions
-                .Select(item => new ImplicitPackageReferenceVersion(item))
-                .Where(item => item.TargetFrameworkVersion == this.TargetFrameworkVersion)
-                .ToDictionary(implicitVersion => implicitVersion.Name);
+            var implicitVersionTable = GetApplicableImplicitVersionTable();
 
             foreach (var packageReference in PackageReferences)
             {
                 ImplicitPackageReferenceVersion implicitVersion;
-                if (implicitReferencesForThisFramework.TryGetValue(packageReference.ItemSpec, out implicitVersion))
+                if (implicitVersionTable.TryGetValue(packageReference.ItemSpec, out implicitVersion))
                 {
                     string versionOnPackageReference = packageReference.GetMetadata(MetadataKeys.Version);
                     if (string.IsNullOrEmpty(versionOnPackageReference))
@@ -63,6 +60,22 @@ protected override void ExecuteCore()
             SdkBuildWarnings = buildWarnings.ToArray();
         }
 
+        private Dictionary<string, ImplicitPackageReferenceVersion> GetApplicableImplicitVersionTable()
+        {
+            var result = new Dictionary<string, ImplicitPackageReferenceVersion>();
+            foreach (var item in ImplicitPackageReferenceVersions)
+            {
+                var implicitPackageReferenceVersion = new ImplicitPackageReferenceVersion(item);
+
+                if (implicitPackageReferenceVersion.TargetFrameworkVersion == this.TargetFrameworkVersion)
+                {
+                    result.Add(implicitPackageReferenceVersion.Name, implicitPackageReferenceVersion);
+                }
+            }
+
+            return result;
+        }
+
         private sealed class ImplicitPackageReferenceVersion
         {
             private ITaskItem _item;

src/Tasks/Microsoft.NET.Build.Tasks/CheckForImplicitPackageReferenceOverrides.cs

@@ -36,11 +36,8 @@ protected override void ExecuteCore()
                         if (item.GetMetadata(MetadataKeys.IsImplicitlyDefined).Equals("true", StringComparison.OrdinalIgnoreCase))
                         {
                             itemsToRemove.Add(item);
-                            string message = string.Format(CultureInfo.CurrentCulture, Strings.PackageReferenceOverrideWarning,
-                                item.ItemSpec,
-                                MoreInformationLink);
-
-                            Log.LogWarning(message);
+  
+                            Log.LogWarning(Strings.PackageReferenceOverrideWarning, item.ItemSpec, MoreInformationLink);
                         }
                         else
                         {