[wasm] Defer parsing of wasm stack symbolication maps #99974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
reviewed
Mar 19, 2024
pavelsavara
reviewed
Mar 19, 2024
Member
|
I like the idea |
…se instead of during startup
kg
force-pushed
the
wasm-demangle-symbol-load
branch
from
ef8780b to
83bc8af
Compare
pavelsavara
approved these changes
Mar 20, 2024
maraf
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if a wasm app's assets list contains symbol maps for stack symbolication, we parse them at startup. This allocates a lot of garbage and is generally slow, and during normal execution the symbol map(s) may never actually be used, so this PR defers the actual parsing until first use.