Avoid leaking pthread flags from zlib-ng.cmake #119487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comment at the start of the file, add_compile_options() and add_linker_flag() will leak to the cmake projects which include zlib-ng.cmake.
github-actions
bot
added
the
needs-area-label
filipnavara
approved these changes
Sep 9, 2025
akoeplinger
added
area-Build-mono
and removed
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CMake configuration issue in the zlib-ng integration where pthread flags were incorrectly being applied globally instead of only to the zlib target. The change prevents pthread compilation and linking flags from leaking to other projects that include the zlib-ng.cmake file.
Key changes:
- Replace global
add_compile_options(-pthread)andadd_linker_flag(-pthread)with target-specific alternatives - Ensure pthread flags only apply to the zlib target when building for browser/WASI platforms
pavelsavara
approved these changes
Sep 9, 2025
pavelsavara
reviewed
Sep 9, 2025
jkoritzinsky
approved these changes
Sep 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment at the start of the file, add_compile_options() and add_linker_flag() will leak to the cmake projects which include zlib-ng.cmake.