Ensure we track MakeGenericType #118479
Merged
Ensure we track MakeGenericType #118479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...even if there's no constructor. This was found in https://github.com/dotnet/runtime/pull/118060/files#r2247963234 but the test case I'm adding is also failing in .NET 9 and doesn't require an IL-only repro to hit.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the NativeAOT compiler where types with required constructors weren't being marked as allocated when they have no actual constructor methods. The fix ensures that types requiring constructors (like structs) are properly marked as allocated during reflection analysis, even when no constructor is found.
Key changes:
- Added explicit allocation marking for types with constructor requirements
- Added test coverage for struct activation scenarios without constructors
- Changed a test attribute from conditional to unconditional
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMarker.cs |
Added allocation marking for types requiring constructors in two methods to ensure they're considered allocated even without explicit constructors |
src/tests/nativeaot/SmokeTests/Reflection/Reflection.cs |
Added comprehensive test case for struct activation scenarios using various methods like Activator.CreateInstance and RuntimeHelpers.GetUninitializedObject |
src/libraries/Common/tests/System/Security/Cryptography/MLKemCngTests.NotSupported.cs |
Changed test attribute from conditional to unconditional |
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Ooof, a bit more than expected. The fact that the Size statistics
|
sbomer
approved these changes
Aug 7, 2025
src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/ValueType.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMarker.cs
Outdated
Show resolved
Hide resolved
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Aug 8, 2025
We don't need reflection metadata to answer this. Change salvaged out of dotnet#118479, rt-sz will decide if we want it.
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Aug 8, 2025
I'm not completely sure this is a fine assumption to make (we're assuming something that RyuJIT should do). Wanted to collect numbers if this is worth pursuing. Change salvaged out of dotnet#118479, rt-sz will decide if we want to pursue it.
Member
Author
|
Much better now. Tge regression in Avalonia is caused by tons of Func/Action delegates used with MakeGeneric in S.L.Expressions implementation. It fixes a correctness issue: Size statisticsPull request #118479
|
MichalStrehovsky
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...even if there's no member access following the call.
This was found in https://github.com/dotnet/runtime/pull/118060/files#r2247963234 but the test case I'm adding is also failing in .NET 9 and doesn't require an IL-only repro to hit because all we need is a struct.