Skip to content

update comment #116869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

update comment #116869

merged 1 commit into from
Jun 20, 2025

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Jun 20, 2025

Follow up #116843 (comment)

Copilot AI review requested due to automatic review settings June 20, 2025 16:57
Copilot AI reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Corrects a comment in the loop alignment logic to reference the updated emitAlignLastGroup field.

  • Updated comment in emit.cpp to match the variable name change from emitAlignLast to emitAlignLastGroup.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 20, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 20, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak mentioned this pull request Jun 20, 2025
Merged
@kunalspathak kunalspathak requested a review from AndyAyersMS June 20, 2025 17:07
@kunalspathak kunalspathak merged commit 03644f0 into dotnet:main Jun 20, 2025
110 checks passed
@kunalspathak kunalspathak deleted the align-comment branch June 20, 2025 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunalspathak @AndyAyersMS