-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Optimize bit operations of BigInteger #113005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
src/libraries/System.Runtime.Numerics/src/System/Numerics/NumericsHelpers.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/NumericsHelpers.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
Outdated
Show resolved
Hide resolved
|
@tannergooding I know we've talked (for a long time) about substantial overhauls (rewrites) of how BigInteger is implemented, and I have been sitting on this PR (sorry, @kzrnm) for a long time because I've been unsure if we should take incremental but still sizeable changes. I'm inclined to accept this change though, even if we do end up doing more substantial work later. What do you think? |
This PR is a refactored version of #112632.
Benchmark