Fix a set of minor DAC bugs I encountered recently #100031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In src/coreclr/debug/daccess/dacdbiimpl.cpp - If g_pDebugger is NULL, produce an error, or NULL result instead of an invalid memory access. - This caused problems when debugging with a debug version of the DAC In src/coreclr/debug/di/module.cpp - Avoid attempting to get the MapAddr if the number of entries in the map is 0, as it may not yet be fully initialized and attempting to call the GetMapAddr function may cause an ASSERT in debug/checked versions of the DAC In src/coreclr/utilcode/collections.cpp - If a CHashTable is not fully initialized, or is in an intermediate state, its possible for the linked list to have an infinite cycle. Tweak the iteration here under the DAC to stop - This is known to cause stack walking to loop infinitely in the debugger when debugging a runtime which has suspended at a non-safe point
ghost
added
the
Contributor
|
Tagging subscribers to this area: @tommcdon |
mikem8361
approved these changes
Mar 20, 2024
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9946790183 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In src/coreclr/debug/daccess/dacdbiimpl.cpp
g_pDebuggeris NULL, produce an error, or NULL result instead of an invalid memory access.In src/coreclr/debug/di/module.cpp
MapAddrif the number of entries in the map is 0, as it may not yet be fully initialized and attempting to call theGetMapAddrfunction may cause an ASSERT in debug/checked versions of the DACIn src/coreclr/utilcode/collections.cpp
CHashTableis not fully initialized, or is in an intermediate state, its possible for the linked list to have an infinite cycle. Tweak the iteration here under the DAC to stop