Skip to content

Commit 463869b

Browse files
authored
XUnitLogChecker: Ensure missing stack frames are resolved on Windows using dotnet-sos (#98397)
* XUnitLogChecker: Ensure missing stack frames are resolved on Windows using dotnet-sos and setting the missing required environment variable.
1 parent ac94075 commit 463869b

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/libraries/sendtohelixhelp.proj

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,20 @@
240240
</ItemGroup>
241241
</Target>
242242

243+
<!-- XUnitLogChecker required configuration -->
243244
<ItemGroup Condition="Exists('$(XUnitLogCheckerLibrariesOutDir)')">
244245
<HelixCorrelationPayload Include="$(XUnitLogCheckerLibrariesOutDir)" />
245-
</ItemGroup>
246+
<HelixCorrelationPayload Condition="'$(WindowsShell)' == 'true'" Include="dotnet-sos">
247+
<Destination>sos</Destination>
248+
<Uri>https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/flat2/dotnet-sos/$(DotnetSosVersion)/dotnet-sos.$(DotnetSosVersion).nupkg</Uri>
249+
</HelixCorrelationPayload>
250+
</ItemGroup>
251+
252+
<PropertyGroup Condition="'$(TargetOS)' == 'windows'">
253+
<NtSymbolPathEnvVar>set _NT_SYMBOL_PATH=%25HELIX_CORRELATION_PAYLOAD%25%3B%25HELIX_CORRELATION_PAYLOAD%25\PDB%3B%25HELIX_CORRELATION_PAYLOAD%25\shared\$(MicrosoftNetCoreAppFrameworkName)\$(ProductVersion)</NtSymbolPathEnvVar>
254+
<ExecuteDotNetSos>%25HELIX_CORRELATION_PAYLOAD%25\dotnet %25HELIX_CORRELATION_PAYLOAD%25\sos\tools\net$(DotnetSosTargetFrameworkVersion)\any\dotnet-sos.dll install --architecture $(TargetArchitecture)</ExecuteDotNetSos>
255+
<HelixPreCommands>$(HelixPreCommands);$(NtSymbolPathEnvVar);$(ExecuteDotNetSos)</HelixPreCommands>
256+
</PropertyGroup>
246257

247258
<!--
248259
Create all the Helix data to start a set of jobs. Create a set of work items, one for each libraries

0 commit comments

Comments
 (0)