Skip to content

Commit 7f9cb0b

Browse files
Update ordering in CodeOwners (#6085)
Place the rules for MEAI.Evaluation after MEAI since the last matching pattern always takes most precendence. I was seeing that `@dotnet/dotnet-extensions-ai` was being included as a reviewer for changes in the `/src/Libraries/Microsoft.Extensions.AI.Evaluation` folder. I think this was happening because the rule for this folder appeared *before* the rule for `/src/Libraries/Microsoft.Extensions.AI.*` in the CODEOWNERS file, and because the last matching pattern always takes precedence. This change should hopefully remedy this and ensure that only @dotnet/dotnet-extensions-ai-evaluation is included as a reviewer for changes in the `/src/Libraries/Microsoft.Extensions.AI.Evaluation` folder.
1 parent 64108d7 commit 7f9cb0b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@
1818
/eng/ @dotnet/dotnet-extensions-infra
1919

2020
/src/Libraries/Microsoft.Extensions.AI @dotnet/dotnet-extensions-ai
21-
/src/Libraries/Microsoft.Extensions.AI.Evaluation @dotnet/dotnet-extensions-ai-evaluation
2221
/src/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai
23-
/src/Libraries/Microsoft.Extensions.AI.Evaluation.* @dotnet/dotnet-extensions-ai-evaluation
2422
/test/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai
23+
24+
/src/Libraries/Microsoft.Extensions.AI.Evaluation @dotnet/dotnet-extensions-ai-evaluation
25+
/src/Libraries/Microsoft.Extensions.AI.Evaluation.* @dotnet/dotnet-extensions-ai-evaluation
2526
/test/Libraries/Microsoft.Extensions.AI.Evaluation.* @dotnet/dotnet-extensions-ai-evaluation
2627

2728
/src/Libraries/Microsoft.Extensions.Caching.Hybrid @dotnet/dotnet-extensions-caching-hybrid

0 commit comments

Comments
 (0)