This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix default style argument to Double/Single/Decimal.Parse #29099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy-and-paste error while adding in the Span-based overload lead to these having the wrong default style. This wasn't caught by tests because a) the existing string-based tests were using the wrong default style (probably also a copy-and-paste error) such that the relevant string-based overloads weren't actually being tested as thought, and b) that code wasn't added to the span-based tests anyway. I've fixed the ref, fixed the string-based tests, and copied/modified the tests for the span-based overloads as well.
jkotas
approved these changes
Apr 13, 2018
Member
Author
|
@dotnet-bot test OSX x64 Debug Build please (HttpListener test) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…efx#29099) Copy-and-paste error while adding in the Span-based overload lead to these having the wrong default style. This wasn't caught by tests because a) the existing string-based tests were using the wrong default style (probably also a copy-and-paste error) such that the relevant string-based overloads weren't actually being tested as thought, and b) that code wasn't added to the span-based tests anyway. I've fixed the ref, fixed the string-based tests, and copied/modified the tests for the span-based overloads as well. Commit migrated from dotnet/corefx@1e0148b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-and-paste error while adding in the Span-based overload led to these having the wrong default style. This wasn't caught by tests because a) the existing string-based tests were using the wrong default style (probably also a copy-and-paste error) such that the relevant string-based overloads weren't actually being tested as thought, and b) that code wasn't added to the span-based tests anyway. I've fixed the ref, fixed the string-based tests, and copied/modified the tests for the span-based overloads as well.
Fixes https://github.com/dotnet/coreclr/issues/17553
Related to dotnet/coreclr#17556
cc: @jkotas