From 213da952ee58568f16c21b10ae84cd127154dbaa Mon Sep 17 00:00:00 2001 From: Egor Chesakov Date: Tue, 5 Feb 2019 11:20:52 -0800 Subject: [PATCH 1/2] Enable baseservices/threading/paramthreadstart/ThreadStartString_1 --- tests/issues.targets | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/issues.targets b/tests/issues.targets index 022f1968c46f..b6083d60e3cf 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -60,9 +60,6 @@ - - 3627 - Issue building native components for the test. @@ -1781,9 +1778,6 @@ needs triage - - needs triage - needs triage From 834e3fc269a46e1bb81a4782ccb14b83ed13fa05 Mon Sep 17 00:00:00 2001 From: Egor Chesakov Date: Mon, 4 Feb 2019 18:33:25 -0800 Subject: [PATCH 2/2] Treat $(CLRTestExecutionArguments) as an array in Bash --- tests/src/CLRTest.Execute.Bash.targets | 12 ++++++------ tests/src/CLRTest.Jit.targets | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/src/CLRTest.Execute.Bash.targets b/tests/src/CLRTest.Execute.Bash.targets index 480a31355c2f..a73f20555c8c 100644 --- a/tests/src/CLRTest.Execute.Bash.targets +++ b/tests/src/CLRTest.Execute.Bash.targets @@ -122,7 +122,7 @@ echo BEGIN EXECUTION]]> - + @@ -271,8 +271,8 @@ else LAUNCHER="$_DebuggerFullPath $(_CLRTestRunFile)" fi -echo $LAUNCHER $ExePath $CLRTestExecutionArguments -$LAUNCHER $ExePath $CLRTestExecutionArguments +echo $LAUNCHER $ExePath %24(printf "'%s' " "${CLRTestExecutionArguments[@]}") +$LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}" CLRTestExitCode=$? if [ ! -z ${RunCrossGen+x} ]%3B then @@ -284,8 +284,8 @@ $(BashLinkerTestCleanupCmds) $(BashCLRTestLaunchCmds) echo export CDPATH="$%28dirname "$0")" export CDPATH="$%28dirname "$0")" -echo /bin/sh $(InputAssemblyName) -/bin/sh $(InputAssemblyName) +echo /usr/bin/env bash $(InputAssemblyName) %24(printf "'%s' " "${CLRTestExecutionArguments[@]}") +/usr/bin/env bash $(InputAssemblyName) "${CLRTestExecutionArguments[@]}" CLRTestExitCode=$? CLRTestExpectedExitCode=0 ]]> @@ -341,7 +341,7 @@ for i in "$@" %(Command) %3B%3B') *) - CLRTestExecutionArguments="$CLRTestExecutionArguments $i" + CLRTestExecutionArguments+=("${i}") esac done diff --git a/tests/src/CLRTest.Jit.targets b/tests/src/CLRTest.Jit.targets index 61e7155556de..b68bed91a286 100644 --- a/tests/src/CLRTest.Jit.targets +++ b/tests/src/CLRTest.Jit.targets @@ -115,8 +115,8 @@ fi