From 030d45776effa1f42b241560b76a411f821a3b1f Mon Sep 17 00:00:00 2001 From: Justin Kotalik Date: Thu, 7 Feb 2019 18:33:45 -0800 Subject: [PATCH 1/2] Re-enable tests --- src/Http/Http/test/StreamPipeReaderTests.cs | 2 +- src/Http/Http/test/StreamPipeWriterTests.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Http/Http/test/StreamPipeReaderTests.cs b/src/Http/Http/test/StreamPipeReaderTests.cs index b85a602c6d8b..b4dd9853c353 100644 --- a/src/Http/Http/test/StreamPipeReaderTests.cs +++ b/src/Http/Http/test/StreamPipeReaderTests.cs @@ -148,7 +148,7 @@ public async Task ReadExamineEntireReadAsyncReturnsNewData() Assert.NotEqual(readResult, readResult2); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task ReadCanBeCancelledViaProvidedCancellationToken() { var pipeReader = new StreamPipeReader(new HangingStream()); diff --git a/src/Http/Http/test/StreamPipeWriterTests.cs b/src/Http/Http/test/StreamPipeWriterTests.cs index e2bfb584b6c9..cc53e2b95922 100644 --- a/src/Http/Http/test/StreamPipeWriterTests.cs +++ b/src/Http/Http/test/StreamPipeWriterTests.cs @@ -133,7 +133,7 @@ public async Task FlushAsyncReturnsCanceledInterleaved() } } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task CancelPendingFlushBetweenWritesAllDataIsPreserved() { MemoryStream = new SingleWriteStream(); @@ -206,7 +206,7 @@ public async Task CancelPendingFlushAfterAllWritesAllDataIsPreserved() Assert.True(flushResult.IsCanceled); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task CancelPendingFlushLostOfCancellationsNoDataLost() { var writeSize = 16; From 07c1f9b7f1473e0c6c47eef44410bdfcb2124ad3 Mon Sep 17 00:00:00 2001 From: Justin Kotalik Date: Fri, 8 Feb 2019 08:45:26 -0800 Subject: [PATCH 2/2] More skipped tests --- src/Http/Http/test/StreamPipeReaderTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Http/Http/test/StreamPipeReaderTests.cs b/src/Http/Http/test/StreamPipeReaderTests.cs index b4dd9853c353..15c578ef3ed1 100644 --- a/src/Http/Http/test/StreamPipeReaderTests.cs +++ b/src/Http/Http/test/StreamPipeReaderTests.cs @@ -157,7 +157,7 @@ public async Task ReadCanBeCancelledViaProvidedCancellationToken() await Assert.ThrowsAsync(async () => await pipeReader.ReadAsync(cts.Token)); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task ReadCanBeCanceledViaCancelPendingReadWhenReadIsAsync() { var pipeReader = new StreamPipeReader(new HangingStream());