[blazor] Diagnostic metrics - OTEL names review #62754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…render_diff.duration and aspnetcore.components.render_diff.size - rename aspnetcore.components.navigation to aspnetcore.components.navigate to match the trace name - rename aspnetcore.components.event_handler to aspnetcore.components.handle_event.duration to match the trace name - rename aspnetcore.components.update_parameters to aspnetcore.components.update_parameters.duration - update unit tests
There was a problem hiding this comment.
Pull Request Overview
This PR aligns Blazor diagnostic metric names with OTEL conventions, splits the render diff metric into separate duration and size histograms, and updates corresponding unit tests.
- Renamed several metrics to include
.durationor match trace names - Added a new histogram for diff size and its bucket boundaries
- Updated unit tests to use renamed metrics and include the new batch size metric
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Shared/Metrics/MetricsConstants.cs | Added bucket boundaries for diff length histogram |
| src/Components/Components/src/ComponentsMetrics.cs | Renamed metrics, added _batchSize histogram, updated recording logic |
| src/Components/Components/test/ComponentsMetricsTest.cs | Updated tests for renamed metrics and new batch size metric |
Comments suppressed due to low confidence (1)
src/Components/Components/test/ComponentsMetricsTest.cs:384
- [nitpick] Consider adding a test to verify that the batch size histogram is also recorded on error paths and that recorded values fall into expected buckets.
Assert.True(batchSizeMeasurements[0].Value > 0);
JamesNK
reviewed
Jul 16, 2025
| @@ -14,6 +14,9 @@ internal static class MetricsConstants | |||
| // For blazor rendering, which should be very fast. | |||
| public static readonly IReadOnlyList<double> BlazorRenderingSecondsBucketBoundaries = [0.000001, 0.00001, 0.0001, 0.001, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10]; | |||
There was a problem hiding this comment.
This has more buckets than other durations (18 compared to 14). I don't know if that's a problem or not, but it's an inconsistency.
| @@ -20,6 +20,7 @@ internal sealed class ComponentsMetrics : IDisposable | |||
| private readonly Histogram<double> _eventDuration; | |||
| private readonly Histogram<double> _parametersDuration; | |||
| private readonly Histogram<double> _batchDuration; | |||
| private readonly Histogram<int> _batchSize; | |||
There was a problem hiding this comment.
I'm guessing that there would never be more than int.MaxValue items rendered in a batch
Co-authored-by: James Newton-King <[email protected]>
Co-authored-by: James Newton-King <[email protected]>
Co-authored-by: James Newton-King <[email protected]>
javiercn
reviewed
Jul 17, 2025
javiercn
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnetcore.components.render_diffintoaspnetcore.components.render_diff.durationaspnetcore.components.render_diff.sizeaspnetcore.components.navigationtoaspnetcore.components.navigateto match the trace nameaspnetcore.components.event_handlertoaspnetcore.components.handle_event.durationto match the trace nameaspnetcore.components.update_parameterstoaspnetcore.components.update_parameters.durationFixes #62555