From 196ca5d3a76523dbb47d3d470f91563bebab9e45 Mon Sep 17 00:00:00 2001 From: Javier Calvarro Nelson Date: Tue, 25 Mar 2025 10:43:09 +0100 Subject: [PATCH 1/3] [Blazor] Changes from API proposal for CloseColumnOptionsAsync --- .../src/PublicAPI.Unshipped.txt | 2 +- .../src/QuickGrid.razor.cs | 2 +- src/Components/test/E2ETest/Tests/QuickGridTest.cs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/PublicAPI.Unshipped.txt b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/PublicAPI.Unshipped.txt index ada74ec6a845..a5806f90a9db 100644 --- a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/PublicAPI.Unshipped.txt +++ b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/PublicAPI.Unshipped.txt @@ -1,4 +1,4 @@ #nullable enable -Microsoft.AspNetCore.Components.QuickGrid.QuickGrid.CloseColumnOptionsAsync() -> System.Threading.Tasks.Task! +Microsoft.AspNetCore.Components.QuickGrid.QuickGrid.HideColumnOptionsAsync() -> System.Threading.Tasks.Task! Microsoft.AspNetCore.Components.QuickGrid.QuickGrid.RowClass.get -> System.Func? Microsoft.AspNetCore.Components.QuickGrid.QuickGrid.RowClass.set -> void \ No newline at end of file diff --git a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs index c5fcebc1fc97..363ad846cbf7 100644 --- a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs +++ b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs @@ -280,7 +280,7 @@ public Task ShowColumnOptionsAsync(ColumnBase column) /// /// Closes the UI that was previously displayed. /// - public Task CloseColumnOptionsAsync() + public Task HideColumnOptionsAsync() { _displayOptionsForColumn = null; StateHasChanged(); diff --git a/src/Components/test/E2ETest/Tests/QuickGridTest.cs b/src/Components/test/E2ETest/Tests/QuickGridTest.cs index 3e071b8686c7..9e470e838007 100644 --- a/src/Components/test/E2ETest/Tests/QuickGridTest.cs +++ b/src/Components/test/E2ETest/Tests/QuickGridTest.cs @@ -177,14 +177,14 @@ public void CanCloseColumnOptionsByBlurring() } [Fact] - public void CanCloseColumnOptionsByCloseColumnOptionsAsync() + public void CanCloseColumnOptionsByHideColumnOptionsAsync() { var grid = app.FindElement(By.CssSelector("#grid > table")); var firstNameColumnOptionsButton = grid.FindElement(By.CssSelector("thead > tr > th:nth-child(2) > div > button[title=\"Column options\"]")); firstNameColumnOptionsButton.Click(); - // Click the button inside the column options popup to close, which calls QuickGrid.CloseColumnOptionsAsync + // Click the button inside the column options popup to close, which calls QuickGrid.HideColumnOptionsAsync grid.FindElement(By.CssSelector("#close-column-options")).Click(); var firstNameSearchSelector = "#grid > table > thead > tr > th:nth-child(2) input[type=search]"; From 672a7e70f713c4c4175679ffd5253e31ce67a79d Mon Sep 17 00:00:00 2001 From: Javier Calvarro Nelson Date: Tue, 25 Mar 2025 11:54:29 +0100 Subject: [PATCH 2/3] Fix missing rename --- .../src/QuickGrid.razor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor index 2200bf600216..5228ed1d2b00 100644 --- a/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor +++ b/src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor @@ -10,7 +10,7 @@ @{ FinishCollectingColumns(); } - +
@_renderColumnHeaders From 43dc46f951b1f0452992dad5c3f1e30b6752c4e3 Mon Sep 17 00:00:00 2001 From: Javier Calvarro Nelson Date: Tue, 25 Mar 2025 12:49:41 +0100 Subject: [PATCH 3/3] Fix more renames --- .../BasicTestApp/QuickGridTest/SampleQuickGridComponent.razor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Components/test/testassets/BasicTestApp/QuickGridTest/SampleQuickGridComponent.razor b/src/Components/test/testassets/BasicTestApp/QuickGridTest/SampleQuickGridComponent.razor index 98bb2a931256..33118db61f51 100644 --- a/src/Components/test/testassets/BasicTestApp/QuickGridTest/SampleQuickGridComponent.razor +++ b/src/Components/test/testassets/BasicTestApp/QuickGridTest/SampleQuickGridComponent.razor @@ -10,7 +10,7 @@ - +