From 40874ba1f3075494f356b89cb65450fe620a85f7 Mon Sep 17 00:00:00 2001 From: Mitch Denny Date: Tue, 21 May 2024 11:16:48 +1000 Subject: [PATCH] Comment out selenium/standalone-chrome container images. --- .../benchmarkapps/Wasm.Performance/dockerfile | 13 ++++++++++++- .../benchmarkapps/Wasm.Performance/local.dockerfile | 13 ++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/Components/benchmarkapps/Wasm.Performance/dockerfile b/src/Components/benchmarkapps/Wasm.Performance/dockerfile index 0e7c062b72cd..c11105625d2e 100644 --- a/src/Components/benchmarkapps/Wasm.Performance/dockerfile +++ b/src/Components/benchmarkapps/Wasm.Performance/dockerfile @@ -29,7 +29,18 @@ RUN .dotnet/dotnet publish -c Release --no-restore -o /app ./src/Components/benc RUN chmod +x /app/Wasm.Performance.Driver WORKDIR /app -FROM selenium/standalone-chrome:124.0 as final +# NOTE: This has been commented out because it is causing our builds to get a build warning +# because we are pulling this container image from docker.io. We should consider whether +# we need this code in our repo at all, and if not remove it. +# If we do need it then we need to get the container image imported into mcr.microsoft.com +# +# I have opened up a PR to do this, however it is not certain we'll be allowed to do this +# and there is further legal/compliance work that needs to be done. In the meantime commenting +# this out should get our builds to green again whilst this issue is resolved. +# +# PR: https://github.com/microsoft/mcr/pull/3232 +# +# FROM selenium/standalone-chrome:124.0 as final COPY --from=build ./app ./ COPY ./exec.sh ./ diff --git a/src/Components/benchmarkapps/Wasm.Performance/local.dockerfile b/src/Components/benchmarkapps/Wasm.Performance/local.dockerfile index c2e1dcd10c5e..2ba34f7da21d 100644 --- a/src/Components/benchmarkapps/Wasm.Performance/local.dockerfile +++ b/src/Components/benchmarkapps/Wasm.Performance/local.dockerfile @@ -1,4 +1,15 @@ -FROM selenium/standalone-chrome:latest as final +# NOTE: This has been commented out because it is causing our builds to get a build warning +# because we are pulling this container image from docker.io. We should consider whether +# we need this code in our repo at all, and if not remove it. +# If we do need it then we need to get the container image imported into mcr.microsoft.com +# +# I have opened up a PR to do this, however it is not certain we'll be allowed to do this +# and there is further legal/compliance work that needs to be done. In the meantime commenting +# this out should get our builds to green again whilst this issue is resolved. +# +# PR: https://github.com/microsoft/mcr/pull/3232 +# +# FROM selenium/standalone-chrome:latest as final ENV StressRunDuration=0