Add SectionName to SectionOutlet and SectionContent #47221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Eilon
reviewed
Mar 15, 2023
…ption of SectionName and SectionId
Flachdachs
reviewed
Apr 2, 2023
| } | ||
|
|
||
| _registry.AddProvider(_identifier, this, IsDefaultContent); | ||
| _registeredIdentifier = SectionId; |
There was a problem hiding this comment.
Now that you also can use SectionName to identify a section _registeredIdentifier should be set to identifier instead of SectionId. Otherwise when using the SectionName it would be null, and RemoveProvider isn't called when it should.
The same issue exists in SectionOutlet.
There was a problem hiding this comment.
@Flachdachs this is a closed PR, so could you log an issue with details around your concern?
There was a problem hiding this comment.
Of course. Actually my intention was to open an issue. I visited the page with the changes anonymously. It offered a "New Issue" button. But as I opened the same URL as logged in user the button was replaced with a Create Review button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SectionName to SectionOutlet and SectionContent
Description
New API Proposal for Sections Support. Adding
SectionNameFixes #46937