From 638d7938c13a5947305e9c6a762d2ec3e39f1a6c Mon Sep 17 00:00:00 2001 From: Bruno Oliveira Date: Tue, 2 Aug 2022 14:12:42 -0700 Subject: [PATCH 1/2] Remove call to .Any() --- .../src/DefaultProblemDetailsWriter.cs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs b/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs index 2bedccd8254a..78c48c7c977a 100644 --- a/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs +++ b/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs @@ -26,9 +26,18 @@ public bool CanWrite(ProblemDetailsContext context) var httpContext = context.HttpContext; var acceptHeader = httpContext.Request.Headers.Accept.GetList(); - if (acceptHeader?.Any(h => _jsonMediaType.IsSubsetOf(h) || _problemDetailsJsonMediaType.IsSubsetOf(h)) == true) + if (acceptHeader is { Count: > 0 }) { - return true; + for (var i = 0; i < acceptHeader.Count; i++) + { + var acceptHeaderValue = acceptHeader[i]; + + if (_jsonMediaType.IsSubsetOf(acceptHeaderValue) || + _problemDetailsJsonMediaType.IsSubsetOf(acceptHeaderValue)) + { + return true; + } + } } return false; From 52e2811c0677726d09e281da782339a548a87255 Mon Sep 17 00:00:00 2001 From: Bruno Oliveira Date: Tue, 2 Aug 2022 14:58:51 -0700 Subject: [PATCH 2/2] Removing System.Linq --- src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs b/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs index 78c48c7c977a..8949dc7d81cf 100644 --- a/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs +++ b/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Diagnostics.CodeAnalysis; -using System.Linq; using System.Text.Json.Serialization; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Options;