From 1bfa298d316047c6bb78064ec4adc624a001a7a8 Mon Sep 17 00:00:00 2001 From: William Godbe Date: Thu, 28 Jul 2022 15:39:23 -0700 Subject: [PATCH 1/3] Add comment about RequestQuery --- src/Middleware/HttpLogging/src/HttpLoggingFields.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs index 995b2c5478a5..5221e8e13bf6 100644 --- a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs +++ b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs @@ -175,5 +175,8 @@ public enum HttpLoggingFields : long /// the entire request and response body up to the /// and . /// + /// + /// This will not include as it may contain private information. + /// All = Request | Response } From 99305f98832192b5af970081361bbaf3ea9309b7 Mon Sep 17 00:00:00 2001 From: William Godbe Date: Mon, 1 Aug 2022 09:31:42 -0700 Subject: [PATCH 2/3] Update src/Middleware/HttpLogging/src/HttpLoggingFields.cs Co-authored-by: Aditya Mandaleeka --- src/Middleware/HttpLogging/src/HttpLoggingFields.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs index 5221e8e13bf6..46b7d60183e2 100644 --- a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs +++ b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs @@ -176,7 +176,8 @@ public enum HttpLoggingFields : long /// and . /// /// - /// This will not include as it may contain private information. + /// The HTTP Request is not included with this flag as it may contain private information. + /// If desired, it should be explicitly specified with . /// All = Request | Response } From e0043bfb485c5e01c9f835c378416d44a09ef7c2 Mon Sep 17 00:00:00 2001 From: William Godbe Date: Mon, 1 Aug 2022 09:32:31 -0700 Subject: [PATCH 3/3] Update HttpLoggingFields.cs --- src/Middleware/HttpLogging/src/HttpLoggingFields.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs index 46b7d60183e2..82f2cab7088f 100644 --- a/src/Middleware/HttpLogging/src/HttpLoggingFields.cs +++ b/src/Middleware/HttpLogging/src/HttpLoggingFields.cs @@ -158,6 +158,10 @@ public enum HttpLoggingFields : long /// Logging the request body has performance implications, as it requires buffering /// the entire request body up to . /// + /// + /// The HTTP Request is not included with this flag as it may contain private information. + /// If desired, it should be explicitly specified with . + /// Request = RequestPropertiesAndHeaders | RequestBody, ///