From d08f48fd20eaba4d28b38a437a81b59e82b63166 Mon Sep 17 00:00:00 2001 From: Mikel Blanchard Date: Tue, 7 Dec 2021 11:03:07 -0800 Subject: [PATCH 1/3] Decorate priorFeature as nullable on StreamResponseBodyFeature ctor. --- src/Http/Http/src/PublicAPI.Unshipped.txt | 1 + src/Http/Http/src/StreamResponseBodyFeature.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Http/Http/src/PublicAPI.Unshipped.txt b/src/Http/Http/src/PublicAPI.Unshipped.txt index 7dc5c58110bf..9ba615fa6288 100644 --- a/src/Http/Http/src/PublicAPI.Unshipped.txt +++ b/src/Http/Http/src/PublicAPI.Unshipped.txt @@ -1 +1,2 @@ #nullable enable +Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature? priorFeature) -> void diff --git a/src/Http/Http/src/StreamResponseBodyFeature.cs b/src/Http/Http/src/StreamResponseBodyFeature.cs index fd162d953ae7..2d1e26ec7e6a 100644 --- a/src/Http/Http/src/StreamResponseBodyFeature.cs +++ b/src/Http/Http/src/StreamResponseBodyFeature.cs @@ -34,7 +34,7 @@ public StreamResponseBodyFeature(Stream stream) /// /// /// - public StreamResponseBodyFeature(Stream stream, IHttpResponseBodyFeature priorFeature) + public StreamResponseBodyFeature(Stream stream, IHttpResponseBodyFeature? priorFeature) { Stream = stream ?? throw new ArgumentNullException(nameof(stream)); PriorFeature = priorFeature; From 8bba616dc5e43f14074eee31f7be10ed3b06d9c1 Mon Sep 17 00:00:00 2001 From: Mikel Blanchard Date: Tue, 7 Dec 2021 13:42:02 -0800 Subject: [PATCH 2/3] Remove StreamResponseBodyFeature ctor from shipped API. --- src/Http/Http/src/PublicAPI.Shipped.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Http/Http/src/PublicAPI.Shipped.txt b/src/Http/Http/src/PublicAPI.Shipped.txt index cb60f3ee7108..fcfd2858ddc1 100644 --- a/src/Http/Http/src/PublicAPI.Shipped.txt +++ b/src/Http/Http/src/PublicAPI.Shipped.txt @@ -255,7 +255,6 @@ Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Dispose() -> void Microsoft.AspNetCore.Http.StreamResponseBodyFeature.PriorFeature.get -> Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature? Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Stream.get -> System.IO.Stream! Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream) -> void -Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature! priorFeature) -> void Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Writer.get -> System.IO.Pipelines.PipeWriter! Microsoft.Extensions.DependencyInjection.HttpServiceCollectionExtensions override Microsoft.AspNetCore.Http.BindingAddress.Equals(object? obj) -> bool From c23780cfb24d2b8e054b4761891066c427042619 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Tue, 7 Dec 2021 19:50:09 -0800 Subject: [PATCH 3/3] Apply suggestions from code review --- src/Http/Http/src/PublicAPI.Shipped.txt | 1 + src/Http/Http/src/PublicAPI.Unshipped.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Http/Http/src/PublicAPI.Shipped.txt b/src/Http/Http/src/PublicAPI.Shipped.txt index fcfd2858ddc1..cb60f3ee7108 100644 --- a/src/Http/Http/src/PublicAPI.Shipped.txt +++ b/src/Http/Http/src/PublicAPI.Shipped.txt @@ -255,6 +255,7 @@ Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Dispose() -> void Microsoft.AspNetCore.Http.StreamResponseBodyFeature.PriorFeature.get -> Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature? Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Stream.get -> System.IO.Stream! Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream) -> void +Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature! priorFeature) -> void Microsoft.AspNetCore.Http.StreamResponseBodyFeature.Writer.get -> System.IO.Pipelines.PipeWriter! Microsoft.Extensions.DependencyInjection.HttpServiceCollectionExtensions override Microsoft.AspNetCore.Http.BindingAddress.Equals(object? obj) -> bool diff --git a/src/Http/Http/src/PublicAPI.Unshipped.txt b/src/Http/Http/src/PublicAPI.Unshipped.txt index 9ba615fa6288..a158cc48ca22 100644 --- a/src/Http/Http/src/PublicAPI.Unshipped.txt +++ b/src/Http/Http/src/PublicAPI.Unshipped.txt @@ -1,2 +1,3 @@ #nullable enable +*REMOVED*Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature! priorFeature) -> void Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature? priorFeature) -> void