From aaf76cf566e9f09722c2fcceb48a50b360f0e2cf Mon Sep 17 00:00:00 2001 From: John Luo Date: Fri, 2 Jul 2021 13:51:26 -0700 Subject: [PATCH 1/2] Update selenium versions --- eng/Versions.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index b2796069544d..4f6e1bea79e1 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -250,9 +250,9 @@ 0.192.0 3.0.0 7.2.2 - 4.0.0-beta2 + 4.0.0-beta4 91.0.4472.1900 - 4.0.0-beta2 + 4.0.0-beta4 1.4.0 4.0.0 2.2.4 From 82edbff2f90d254a54ada11f4d2fda24cafcab58 Mon Sep 17 00:00:00 2001 From: John Luo Date: Fri, 2 Jul 2021 21:54:51 -0700 Subject: [PATCH 2/2] React to selenium updates --- .../benchmarkapps/Wasm.Performance/Driver/Selenium.cs | 2 +- src/Components/test/E2ETest/Tests/FormsTest.cs | 4 ++-- src/Shared/E2ETesting/BrowserFixture.cs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Components/benchmarkapps/Wasm.Performance/Driver/Selenium.cs b/src/Components/benchmarkapps/Wasm.Performance/Driver/Selenium.cs index b8ba5b1e26a1..666e1a0ea7fc 100644 --- a/src/Components/benchmarkapps/Wasm.Performance/Driver/Selenium.cs +++ b/src/Components/benchmarkapps/Wasm.Performance/Driver/Selenium.cs @@ -93,7 +93,7 @@ public static async Task CreateBrowser(CancellationToken cancel if (PoolForBrowserLogs) { // Run in background. - var logs = new RemoteLogs(driver); + var logs = driver.Manage().Logs; _ = Task.Run(async () => { while (!cancellationToken.IsCancellationRequested) diff --git a/src/Components/test/E2ETest/Tests/FormsTest.cs b/src/Components/test/E2ETest/Tests/FormsTest.cs index aef12b8f2ea2..5440602e4141 100644 --- a/src/Components/test/E2ETest/Tests/FormsTest.cs +++ b/src/Components/test/E2ETest/Tests/FormsTest.cs @@ -608,8 +608,8 @@ public void InputRangeAttributeOrderDoesNotAffectValue() var rangeWithValueLast = appElement.FindElement(By.Id("range-value-last")); // Value never gets incorrectly clamped. - Browser.Equal("210", () => rangeWithValueFirst.GetProperty("value")); - Browser.Equal("210", () => rangeWithValueLast.GetProperty("value")); + Browser.Equal("210", () => rangeWithValueFirst.GetDomProperty("value")); + Browser.Equal("210", () => rangeWithValueLast.GetDomProperty("value")); } private Func CreateValidationMessagesAccessor(IWebElement appElement) diff --git a/src/Shared/E2ETesting/BrowserFixture.cs b/src/Shared/E2ETesting/BrowserFixture.cs index f7d5c8d62a44..a8ca2c0507c9 100644 --- a/src/Shared/E2ETesting/BrowserFixture.cs +++ b/src/Shared/E2ETesting/BrowserFixture.cs @@ -198,7 +198,7 @@ private async Task DeleteBrowserUserProfileDirectoriesAsync() TimeSpan.FromSeconds(60).Add(TimeSpan.FromSeconds(attempt * 60))); driver.Manage().Timeouts().ImplicitWait = TimeSpan.FromSeconds(1); - var logs = new RemoteLogs(driver); + var logs = driver.Manage().Logs; return (driver, logs); } @@ -332,7 +332,7 @@ private string UserProfileDirectory(string context) // Make sure implicit waits are disabled as they don't mix well with explicit waiting // see https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait driver.Manage().Timeouts().ImplicitWait = TimeSpan.Zero; - var logs = new RemoteLogs(driver); + var logs = driver.Manage().Logs; return (driver, logs); }