From 9b475bd5055ec7befc9678f153908450fe74c502 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 1 Apr 2021 13:35:59 -0700 Subject: [PATCH 1/7] Remove baseline suppressions from 5.0 --- .../src/Microsoft.AspNetCore.Components.csproj | 13 ------------- .../UI/src/Microsoft.AspNetCore.Identity.UI.csproj | 5 ----- ...crosoft.AspNetCore.SpaServices.Extensions.csproj | 8 +------- ...osoft.AspNetCore.Connections.Abstractions.csproj | 10 +--------- .../Microsoft.AspNetCore.SignalR.Client.Core.csproj | 5 ----- 5 files changed, 2 insertions(+), 39 deletions(-) diff --git a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj index 3c4e0bc9a706..f11e36cbf81c 100644 --- a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj +++ b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj @@ -20,19 +20,6 @@ - - - - - - - diff --git a/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj b/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj index 55d14d6fe15f..30a591e1db9b 100644 --- a/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj +++ b/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj @@ -36,11 +36,6 @@ - - - - - <_RazorGenerate Include="Areas\Identity\Pages\V4\**\*.cshtml" /> diff --git a/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj b/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj index b0fd0f9f020f..7ffa3d9ca17d 100644 --- a/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj +++ b/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj @@ -16,11 +16,5 @@ - - - - - + diff --git a/src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj b/src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj index 39732e90e605..48fb76432167 100644 --- a/src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj +++ b/src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj @@ -22,13 +22,5 @@ - - - - - - + diff --git a/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj b/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj index 5b57ef111e0d..25e8b560b329 100644 --- a/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj +++ b/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj @@ -30,11 +30,6 @@ - - - - - From 2628a37a90854dabff79c2c0201dc06efce4a8fc Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Fri, 2 Apr 2021 12:39:41 -0700 Subject: [PATCH 2/7] Use newer NuGet.Protocol version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - v4.8.2 ➡️ v5.8.1 --- eng/tools/BaselineGenerator/BaselineGenerator.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/tools/BaselineGenerator/BaselineGenerator.csproj b/eng/tools/BaselineGenerator/BaselineGenerator.csproj index d80ea1277248..46f1511c8dc4 100644 --- a/eng/tools/BaselineGenerator/BaselineGenerator.csproj +++ b/eng/tools/BaselineGenerator/BaselineGenerator.csproj @@ -8,7 +8,7 @@ - + From d81f1b01a931592910f36ce53a178fbdc8acbe1e Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Fri, 2 Apr 2021 13:46:58 -0700 Subject: [PATCH 3/7] Fix condition --- eng/Baseline.Designer.props | 52 +++++++++---------- .../BaselineGenerator.csproj | 2 +- eng/tools/BaselineGenerator/Program.cs | 10 ++-- 3 files changed, 34 insertions(+), 30 deletions(-) diff --git a/eng/Baseline.Designer.props b/eng/Baseline.Designer.props index 60779e1f16b7..00cdc1685bc3 100644 --- a/eng/Baseline.Designer.props +++ b/eng/Baseline.Designer.props @@ -153,7 +153,7 @@ - + @@ -167,7 +167,7 @@ 5.0.4 - + @@ -190,7 +190,7 @@ 5.0.4 - + @@ -198,14 +198,14 @@ 5.0.4 - + 5.0.4 - + @@ -216,7 +216,7 @@ 5.0.4 - + @@ -232,7 +232,7 @@ 5.0.4 - + @@ -243,7 +243,7 @@ 5.0.4 - + @@ -263,7 +263,7 @@ - + @@ -284,7 +284,7 @@ - + @@ -310,7 +310,7 @@ - + @@ -345,7 +345,7 @@ - + @@ -417,7 +417,7 @@ - + @@ -432,7 +432,7 @@ - + @@ -444,7 +444,7 @@ 5.0.4 - + @@ -592,7 +592,7 @@ - + @@ -608,7 +608,7 @@ - + @@ -677,7 +677,7 @@ 5.0.4 - + @@ -725,7 +725,7 @@ - + @@ -756,7 +756,7 @@ - + @@ -772,7 +772,7 @@ 5.0.4 - + @@ -788,7 +788,7 @@ - + @@ -808,7 +808,7 @@ - + @@ -832,7 +832,7 @@ - + @@ -878,7 +878,7 @@ - + @@ -891,7 +891,7 @@ 5.0.4 - + diff --git a/eng/tools/BaselineGenerator/BaselineGenerator.csproj b/eng/tools/BaselineGenerator/BaselineGenerator.csproj index 46f1511c8dc4..d80ea1277248 100644 --- a/eng/tools/BaselineGenerator/BaselineGenerator.csproj +++ b/eng/tools/BaselineGenerator/BaselineGenerator.csproj @@ -8,7 +8,7 @@ - + diff --git a/eng/tools/BaselineGenerator/Program.cs b/eng/tools/BaselineGenerator/Program.cs index 663940f7aa5a..b5ebc76f5f5a 100644 --- a/eng/tools/BaselineGenerator/Program.cs +++ b/eng/tools/BaselineGenerator/Program.cs @@ -100,11 +100,12 @@ private async Task Run() var baselineVersion = input.Root.Attribute("Version").Value; // Baseline and .NET Core versions always align in non-preview releases. - // But, NuspecReader reports netcoreapp5.0 instead of net5.0. We use net5.0 in Baseline.Designer.props. + // But, NuspecReader reports netcoreapp5.0 or net50 instead of net5.0. We use net5.0 in Baseline.Designer.props. var parsedVersion = Version.Parse(baselineVersion); var defaultTarget = ((parsedVersion.Major < 5) ? "netcoreapp" : "net") + $"{parsedVersion.Major}.{parsedVersion.Minor}"; - var matchTarget = $"netcoreapp{parsedVersion.Major}.{parsedVersion.Minor}"; + var netcoreappTarget = $"netcoreapp{parsedVersion.Major}.{parsedVersion.Minor}"; + var netTarget = $"net{parsedVersion.Major}{parsedVersion.Minor}"; var doc = new XDocument( new XComment(" Auto generated. Do not edit manually, use eng/tools/BaselineGenerator/ to recreate. "), @@ -179,7 +180,10 @@ private async Task Run() var targetCondition = $"'$(TargetFramework)' == '{group.TargetFramework.GetShortFolderName()}'"; if (string.Equals( group.TargetFramework.GetShortFolderName(), - matchTarget, + netcoreappTarget, + StringComparison.OrdinalIgnoreCase) || string.Equals( + group.TargetFramework.GetShortFolderName(), + netTarget, StringComparison.OrdinalIgnoreCase)) { targetCondition = From f14648fd61c5563cc10dc7e4908181dd9387c7c7 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Fri, 2 Apr 2021 13:55:42 -0700 Subject: [PATCH 4/7] Back to 5.8.1 --- eng/tools/BaselineGenerator/BaselineGenerator.csproj | 2 +- eng/tools/BaselineGenerator/Program.cs | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/eng/tools/BaselineGenerator/BaselineGenerator.csproj b/eng/tools/BaselineGenerator/BaselineGenerator.csproj index d80ea1277248..46f1511c8dc4 100644 --- a/eng/tools/BaselineGenerator/BaselineGenerator.csproj +++ b/eng/tools/BaselineGenerator/BaselineGenerator.csproj @@ -8,7 +8,7 @@ - + diff --git a/eng/tools/BaselineGenerator/Program.cs b/eng/tools/BaselineGenerator/Program.cs index b5ebc76f5f5a..9c5c8bc07888 100644 --- a/eng/tools/BaselineGenerator/Program.cs +++ b/eng/tools/BaselineGenerator/Program.cs @@ -100,12 +100,9 @@ private async Task Run() var baselineVersion = input.Root.Attribute("Version").Value; // Baseline and .NET Core versions always align in non-preview releases. - // But, NuspecReader reports netcoreapp5.0 or net50 instead of net5.0. We use net5.0 in Baseline.Designer.props. var parsedVersion = Version.Parse(baselineVersion); var defaultTarget = ((parsedVersion.Major < 5) ? "netcoreapp" : "net") + $"{parsedVersion.Major}.{parsedVersion.Minor}"; - var netcoreappTarget = $"netcoreapp{parsedVersion.Major}.{parsedVersion.Minor}"; - var netTarget = $"net{parsedVersion.Major}{parsedVersion.Minor}"; var doc = new XDocument( new XComment(" Auto generated. Do not edit manually, use eng/tools/BaselineGenerator/ to recreate. "), @@ -180,10 +177,7 @@ private async Task Run() var targetCondition = $"'$(TargetFramework)' == '{group.TargetFramework.GetShortFolderName()}'"; if (string.Equals( group.TargetFramework.GetShortFolderName(), - netcoreappTarget, - StringComparison.OrdinalIgnoreCase) || string.Equals( - group.TargetFramework.GetShortFolderName(), - netTarget, + defaultTarget, StringComparison.OrdinalIgnoreCase)) { targetCondition = From 1a18279bbad9d0d7776322564308e757ba91b7fe Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Fri, 2 Apr 2021 14:06:56 -0700 Subject: [PATCH 5/7] Undo components changes --- .../src/Microsoft.AspNetCore.Components.csproj | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj index f11e36cbf81c..3c4e0bc9a706 100644 --- a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj +++ b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj @@ -20,6 +20,19 @@ + + + + + + + From 326921cf01abec2d30937e9f786d79e713153309 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Fri, 2 Apr 2021 14:08:14 -0700 Subject: [PATCH 6/7] Whoops --- .../Components/src/Microsoft.AspNetCore.Components.csproj | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj index 3c4e0bc9a706..3f1c09b7a3d2 100644 --- a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj +++ b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj @@ -28,8 +28,6 @@ Major.Minor during previews. After RTM (and baseline updates), remove suppressions entirely. --> - - From e66790462c869d65204f01af4962f75731cad39a Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Fri, 2 Apr 2021 14:09:04 -0700 Subject: [PATCH 7/7] Whoops --- .../Components/src/Microsoft.AspNetCore.Components.csproj | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj index 3f1c09b7a3d2..6da98d50a9c1 100644 --- a/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj +++ b/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj @@ -28,7 +28,8 @@ Major.Minor during previews. After RTM (and baseline updates), remove suppressions entirely. --> - + +