From c4418e7e853ee6106eb7e83bcfed62343c48dd2d Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Mon, 12 Oct 2020 22:03:11 -0700 Subject: [PATCH 1/5] Raise min Windows version for HTTP/2 tests > [0.019s] [Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware] [Information] HTTP/2 over TLS is not supported on Windows versions older than Windows 10 and Windows Server 2016 due to incompatible ciphers or missing ALPN support. Falling back to HTTP/1.1 instead. --- .../NegotiateHandlerFunctionalTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Security/Authentication/Negotiate/test/Negotiate.FunctionalTest/NegotiateHandlerFunctionalTests.cs b/src/Security/Authentication/Negotiate/test/Negotiate.FunctionalTest/NegotiateHandlerFunctionalTests.cs index 1a1c8def5cce..87e22bde8a57 100644 --- a/src/Security/Authentication/Negotiate/test/Negotiate.FunctionalTest/NegotiateHandlerFunctionalTests.cs +++ b/src/Security/Authentication/Negotiate/test/Negotiate.FunctionalTest/NegotiateHandlerFunctionalTests.cs @@ -69,7 +69,7 @@ public async Task Anonymous_Challenge_401Negotiate_Win7() [ConditionalTheory] [MemberData(nameof(Http11And2))] - [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81, SkipReason = "Windows only supports ALPN on 8.1 and later.")] + [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10, SkipReason = "Windows only supports ALPN and required ciphers on 10 and later.")] public async Task Anonymous_NoChallenge_NoOps(Version version) { using var host = await CreateHostAsync(); @@ -84,7 +84,7 @@ public async Task Anonymous_NoChallenge_NoOps(Version version) [ConditionalTheory] [MemberData(nameof(Http11And2))] - [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81, SkipReason = "Windows only supports ALPN on 8.1 and later.")] + [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10, SkipReason = "Windows only supports ALPN and required ciphers on 10 and later.")] public async Task Anonymous_Challenge_401Negotiate(Version version) { using var host = await CreateHostAsync(); From 85f385804162897d04b35aa3ed34b86a42b03f00 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Mon, 12 Oct 2020 22:11:18 -0700 Subject: [PATCH 2/5] Skip ClientDisconnectStress on Windows 7 --- .../IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs index dba351a50645..a682908f06a6 100644 --- a/src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs +++ b/src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs @@ -666,6 +666,7 @@ await connection.Send( [ConditionalFact] [MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H1, SkipReason = "Shutdown hangs https://github.com/dotnet/aspnetcore/issues/25107")] + [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81, SkipReason = "NullReferenceException https://github.com/dotnet/aspnetcore/issues/26839")] public async Task ClientDisconnectStress() { var maxRequestSize = 1000; From a87992bc1b9f5f4b8fbdd4abc6a19071e336dbff Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Mon, 12 Oct 2020 22:35:01 -0700 Subject: [PATCH 3/5] Skip TlsHandshakeFailure_EmitsStartAndStopEventsWithActivityIds on Win 7 --- .../test/InMemory.FunctionalTests/EventSourceTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/EventSourceTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/EventSourceTests.cs index 372362d720cd..9782539ba180 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/EventSourceTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/EventSourceTests.cs @@ -268,7 +268,8 @@ public async Task Http2_EmitsStartAndStopEventsWithActivityIds() Assert.Equal(eventIndex, events.Count); } - [Fact] + [ConditionalFact] + [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "SslStream.AuthenticateAsServerAsync() doesn't throw on Win 7 when the client tries SSL 2.0.")] public async Task TlsHandshakeFailure_EmitsStartAndStopEventsWithActivityIds() { int port; @@ -298,7 +299,7 @@ public async Task TlsHandshakeFailure_EmitsStartAndStopEventsWithActivityIds() { TargetHost = "localhost", - // Only enabling SslProtocols.Ssl2 should cause a handshake failure on all platforms. + // Only enabling SslProtocols.Ssl2 should cause a handshake failure on most platforms. #pragma warning disable CS0618 // Type or member is obsolete EnabledSslProtocols = SslProtocols.Ssl2, #pragma warning restore CS0618 // Type or member is obsolete From 41fa110397b18d4b9d02801887e555f96579fd6e Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Mon, 12 Oct 2020 22:35:53 -0700 Subject: [PATCH 4/5] Don't run Windows-only tests on ARM yet --- eng/targets/Helix.Common.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/targets/Helix.Common.props b/eng/targets/Helix.Common.props index 0eb345b5755a..87efd43249d0 100644 --- a/eng/targets/Helix.Common.props +++ b/eng/targets/Helix.Common.props @@ -33,7 +33,7 @@ - + @@ -43,7 +43,7 @@ - + From 30cc29231701e9a5e7822fd3ccd9b74ae208af5d Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Tue, 13 Oct 2020 17:04:04 -0700 Subject: [PATCH 5/5] Skip DataProtectionProviderTests.System_UsesProvidedDirectoryAndCertificate on Windows.10.Arm64.Open --- .../Extensions/test/DataProtectionProviderTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataProtection/Extensions/test/DataProtectionProviderTests.cs b/src/DataProtection/Extensions/test/DataProtectionProviderTests.cs index 3d5c59419f5e..8fb700d452da 100644 --- a/src/DataProtection/Extensions/test/DataProtectionProviderTests.cs +++ b/src/DataProtection/Extensions/test/DataProtectionProviderTests.cs @@ -115,7 +115,7 @@ public void System_UsesProvidedDirectory_WithConfigurationCallback() [ConditionalFact] [X509StoreIsAvailable(StoreName.My, StoreLocation.CurrentUser)] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "All.OSX")] + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720 and https://github.com/dotnet/aspnetcore/issues/26871", Queues = "All.OSX;Windows.10.Arm64.Open")] public void System_UsesProvidedDirectoryAndCertificate() { var filePath = Path.Combine(GetTestFilesPath(), "TestCert.pfx");