From a194e65a21dc463eb2f8e43420a09b9b49070ea6 Mon Sep 17 00:00:00 2001
From: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Date: Sun, 11 Oct 2020 13:48:57 -0700
Subject: [PATCH 1/5] !!! Correct condition controlling `public` API analysis
!!! - #26785 demonstrated analyzers were inoperable
---
eng/targets/CSharp.Common.targets | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eng/targets/CSharp.Common.targets b/eng/targets/CSharp.Common.targets
index c9ef556f4d86..3c452ffe40a5 100644
--- a/eng/targets/CSharp.Common.targets
+++ b/eng/targets/CSharp.Common.targets
@@ -18,7 +18,7 @@
$(NoWarn);CA1416
-
@@ -26,7 +26,7 @@
From 656cdaba4d9f2f97b1fb791e207bdd7237d57ad3 Mon Sep 17 00:00:00 2001
From: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Date: Sun, 11 Oct 2020 17:45:18 -0700
Subject: [PATCH 2/5] Remove unused `public` API files
---
src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Shipped.txt | 1 -
.../Manifest.MSBuildTask/src/PublicAPI.Unshipped.txt | 1 -
2 files changed, 2 deletions(-)
delete mode 100644 src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Shipped.txt
delete mode 100644 src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Unshipped.txt
diff --git a/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Shipped.txt b/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Shipped.txt
deleted file mode 100644
index 7dc5c58110bf..000000000000
--- a/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Shipped.txt
+++ /dev/null
@@ -1 +0,0 @@
-#nullable enable
diff --git a/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Unshipped.txt b/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Unshipped.txt
deleted file mode 100644
index 7dc5c58110bf..000000000000
--- a/src/FileProviders/Manifest.MSBuildTask/src/PublicAPI.Unshipped.txt
+++ /dev/null
@@ -1 +0,0 @@
-#nullable enable
From b13c10c58a89c35ab44127deb82cdb4107433aed Mon Sep 17 00:00:00 2001
From: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Date: Sun, 11 Oct 2020 17:46:05 -0700
Subject: [PATCH 3/5] Update `public` API files - three Components files were
missing `#nullable enable` - `nullable` annotations missing or out-of-date
elsewhere
---
.../Components/src/PublicAPI.Unshipped.txt | 43 ++++++++++---------
.../Server/src/PublicAPI.Unshipped.txt | 18 +++++++-
.../Web/src/PublicAPI.Unshipped.txt | 18 ++++----
.../src/PublicAPI.Unshipped.txt | 2 +-
.../Http.Features/src/PublicAPI.Unshipped.txt | 10 ++---
src/Http/Routing/src/PublicAPI.Unshipped.txt | 2 +-
.../src/PublicAPI.Unshipped.txt | 10 ++---
.../Diagnostics/src/PublicAPI.Unshipped.txt | 2 +
src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt | 1 +
.../src/PublicAPI.Unshipped.txt | 1 +
src/ObjectPool/src/PublicAPI.Unshipped.txt | 8 ++--
.../Core/src/PublicAPI.Unshipped.txt | 22 +++++-----
.../server/Core/src/PublicAPI.Unshipped.txt | 18 ++++----
13 files changed, 88 insertions(+), 67 deletions(-)
diff --git a/src/Components/Components/src/PublicAPI.Unshipped.txt b/src/Components/Components/src/PublicAPI.Unshipped.txt
index bccbaa73c306..95903170d0ff 100644
--- a/src/Components/Components/src/PublicAPI.Unshipped.txt
+++ b/src/Components/Components/src/PublicAPI.Unshipped.txt
@@ -1,3 +1,4 @@
+#nullable enable
Microsoft.AspNetCore.Components.BindConverter
Microsoft.AspNetCore.Components.BindElementAttribute
Microsoft.AspNetCore.Components.BindElementAttribute.BindElementAttribute(string! element, string? suffix, string! valueAttribute, string! changeAttribute) -> void
@@ -46,12 +47,12 @@ Microsoft.AspNetCore.Components.EventCallback
Microsoft.AspNetCore.Components.EventCallback.EventCallback(Microsoft.AspNetCore.Components.IHandleEvent? receiver, System.MulticastDelegate? delegate) -> void
Microsoft.AspNetCore.Components.EventCallback.HasDelegate.get -> bool
Microsoft.AspNetCore.Components.EventCallback.InvokeAsync() -> System.Threading.Tasks.Task!
-Microsoft.AspNetCore.Components.EventCallback.InvokeAsync(object! arg) -> System.Threading.Tasks.Task!
+Microsoft.AspNetCore.Components.EventCallback.InvokeAsync(object? arg) -> System.Threading.Tasks.Task!
Microsoft.AspNetCore.Components.EventCallback
Microsoft.AspNetCore.Components.EventCallback.EventCallback(Microsoft.AspNetCore.Components.IHandleEvent? receiver, System.MulticastDelegate? delegate) -> void
Microsoft.AspNetCore.Components.EventCallback.HasDelegate.get -> bool
Microsoft.AspNetCore.Components.EventCallback.InvokeAsync() -> System.Threading.Tasks.Task!
-Microsoft.AspNetCore.Components.EventCallback.InvokeAsync(TValue arg) -> System.Threading.Tasks.Task!
+Microsoft.AspNetCore.Components.EventCallback.InvokeAsync(TValue? arg) -> System.Threading.Tasks.Task!
Microsoft.AspNetCore.Components.EventCallbackFactory
Microsoft.AspNetCore.Components.EventCallbackFactory.Create(object! receiver, Microsoft.AspNetCore.Components.EventCallback callback) -> Microsoft.AspNetCore.Components.EventCallback
Microsoft.AspNetCore.Components.EventCallbackFactory.Create(object! receiver, System.Action! callback) -> Microsoft.AspNetCore.Components.EventCallback
@@ -145,7 +146,7 @@ Microsoft.AspNetCore.Components.ParameterView.Enumerator
Microsoft.AspNetCore.Components.ParameterView.Enumerator.Current.get -> Microsoft.AspNetCore.Components.ParameterValue
Microsoft.AspNetCore.Components.ParameterView.Enumerator.MoveNext() -> bool
Microsoft.AspNetCore.Components.ParameterView.GetEnumerator() -> Microsoft.AspNetCore.Components.ParameterView.Enumerator
-Microsoft.AspNetCore.Components.ParameterView.GetValueOrDefault(string! parameterName) -> TValue
+Microsoft.AspNetCore.Components.ParameterView.GetValueOrDefault(string! parameterName) -> TValue?
Microsoft.AspNetCore.Components.ParameterView.GetValueOrDefault(string! parameterName, TValue defaultValue) -> TValue
Microsoft.AspNetCore.Components.ParameterView.SetParameterProperties(object! target) -> void
Microsoft.AspNetCore.Components.ParameterView.ToDictionary() -> System.Collections.Generic.IReadOnlyDictionary!
@@ -190,30 +191,13 @@ Microsoft.AspNetCore.Components.RenderTree.RenderTreeEditType.UpdateMarkup = 8 -
Microsoft.AspNetCore.Components.RenderTree.RenderTreeEditType.UpdateText = 5 -> Microsoft.AspNetCore.Components.RenderTree.RenderTreeEditType
Microsoft.AspNetCore.Components.RenderTree.RenderTreeFrame
Microsoft.AspNetCore.Components.RenderTree.RenderTreeFrame.AttributeEventHandlerId.get -> ulong
-Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder.AddAttribute(int sequence, string! name, string? value) -> void
-Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder.AddComponentReferenceCapture(int sequence, System.Action