Skip to content

Create a BufferedPipeReader #8165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jkotalik opened this issue Mar 4, 2019 · 5 comments
Open

Create a BufferedPipeReader #8165

jkotalik opened this issue Mar 4, 2019 · 5 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Milestone
Backlog

Comments

@jkotalik
Copy link
Contributor

jkotalik commented Mar 4, 2019 •
edited by analogrelay
Loading

Epic #8829

It can be used by the form reader here: https://github.com/aspnet/AspNetCore/blob/f2e6e6ff334176540ef0b3291122e359c2106d1a/src/Http/Http/src/Features/FormFeature.cs#L139-L142. This can be a fairly simple wrapper which continually calls AdvanceTo(Start, End) on the inner PipeReader.
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 4, 2019

@davidfowl

@Tratcher
Copy link
Member

Tratcher commented Mar 4, 2019

Except then you need a way to get back to the lower level unconsumed pipe. EnablePipeRewind and RewindPipe()?

@davidfowl
Copy link
Member

Right, there's no way to seek so maybe a new API to get the body would be better.

@muratg muratg added this to the 3.0.0-preview6 milestone Mar 7, 2019
@analogrelay analogrelay mentioned this issue Mar 26, 2019
Closed
1 task
@analogrelay analogrelay added the blocked The work on this issue is blocked due to some dependency label Mar 27, 2019
@analogrelay
Copy link
Contributor

We're waiting on the corefx work to settle a bit before we can do this.

@davidfowl davidfowl modified the milestones: 3.0.0-preview6, Backlog Apr 12, 2019
@davidfowl
Copy link
Member

Megabacklog

@pranavkm pranavkm removed the cost: S label Nov 6, 2020
@jkotalik jkotalik added affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@analogrelay @davidfowl @pranavkm @muratg @Tratcher @jkotalik @amcasey