-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove dependencies from the default set adding by ConfigureWebHost #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you tracking the removal of server.Urls and other obsolete config settings somewhere? |
I removed the server.urls in the PR. |
What does this phrase in the announcement mean? |
@sandersaares Components that require the ObjectPoolProvider add it instead of it being added for everyone (it was only used in 3 places). Where as something like logging is user by every component. |
I'm not a big fan of dependencies being added by default, and I suspect there are going to be more cases where dependencies are added like so, is there going to be a wider review to see if we can make improvements elsewhere as part of this breaking change? |
Yes the dependencies listed are the ones that are problematic/unnecessary. The other dependencies are pretty much required to function. |
I'm not sure we can easily remove the diagnostic source. I need to think about that one more. |
Closing this as we're not going to remove (at least in the short term, the DiagnosticSource) |
Today we add a set of dependencies that mirror the WebHostBuilder https://github.com/aspnet/Hosting/blob/d7b9fd480765bdc01f06441f308fb288e6001049/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs#L270-L285. Things we may want to remove:
@Tratcher @rynowak
The text was updated successfully, but these errors were encountered: