Skip to content

Don't reject ambiguous forms until we try to dispatch the submit event #49362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteveSandersonMS opened this issue Jul 12, 2023 · 0 comments · Fixed by #49340
Closed

Don't reject ambiguous forms until we try to dispatch the submit event #49362

SteveSandersonMS opened this issue Jul 12, 2023 · 0 comments · Fixed by #49340
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-full-stack-web-ui Full stack web UI with Blazor
Milestone

Comments

@SteveSandersonMS
Copy link
Member

Follow-up on the second half of #49298 (comment)

Currently, the SSR renderer will throw during the initial page load if it tries to render multiple named events with clashing names. We can change this to not throw unless you actually try to dispatch the event with the ambiguous name.

It should be fairly straightforwards as we just need to update EndpointHtmlRenderer so that instead of tracking the named events in a dictionary name->location, it tracks a name->hashset<location>, and then we can throw if that hashset has > 1 member at the time we come to dispatch it.

@SteveSandersonMS SteveSandersonMS added area-blazor Includes: Blazor, Razor Components feature-full-stack-web-ui Full stack web UI with Blazor labels Jul 12, 2023
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jul 13, 2023
@mkArtakMSFT mkArtakMSFT added this to the 8.0-rc1 milestone Jul 13, 2023
@mkArtakMSFT mkArtakMSFT modified the milestones: 8.0-rc1, 8.0-preview7 Jul 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-full-stack-web-ui Full stack web UI with Blazor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@SteveSandersonMS @mkArtakMSFT and others