Skip to content

CascadingModelBinder: remove the IsFixed parameter #47902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveSandersonMS opened this issue Apr 26, 2023 · 1 comment
Closed

CascadingModelBinder: remove the IsFixed parameter #47902

SteveSandersonMS opened this issue Apr 26, 2023 · 1 comment
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Priority:0 Work that we can't release without
Milestone
8.0-preview7

Comments

@SteveSandersonMS
Copy link
Member

The new and as-yet unshipped CascadingModelBinder has an IsFixed parameter to control whether the name is allowed to vary. It turns out this is not required because there isn't any situation where the name would need to change dynamically.

By removing this flag, and making it behave as fixed in all cases:

  • We always get the performance benefits of the underlying CascadingValue being flagged as fixed
  • The implementation of CascadingModelBinder gets simplified a lot - much of the logic relating to checking what's changed and dynamically (re)creating the model binding context can be removed or turned into a simple one-time setup mechanism

We need to do this before .NET 8 ships to avoid it being a breaking change later.
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Apr 26, 2023
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Apr 26, 2023
@mkArtakMSFT mkArtakMSFT added this to the .NET 8 Planning milestone Apr 26, 2023
@mkArtakMSFT mkArtakMSFT added the Priority:0 Work that we can't release without label Apr 26, 2023
@dotnet dotnet deleted a comment Apr 26, 2023
@javiercn javiercn mentioned this issue May 24, 2023
Merged
@SteveSandersonMS SteveSandersonMS mentioned this issue Jul 7, 2023
Merged
@SteveSandersonMS
Copy link
Member Author

Done in #49340

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Priority:0 Work that we can't release without
Projects
None yet
Milestone
8.0-preview7
Development

No branches or pull requests
3 participants
@SteveSandersonMS @javiercn @mkArtakMSFT