Skip to content

[blazor] Remove reference to BINDING api in global namespace #47878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maraf opened this issue Apr 25, 2023 · 6 comments · Fixed by dotnet/sdk#32121 or #47964
Closed

[blazor] Remove reference to BINDING api in global namespace #47878

maraf opened this issue Apr 25, 2023 · 6 comments · Fixed by dotnet/sdk#32121 or #47964
Assignees
@MackinnonBuck
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly task
Milestone
8.0-preview5

Comments

@maraf
Copy link
Member

maraf commented Apr 25, 2023

The blazor hotreload feature expects BINDING api to be exported to global namespace in the https://github.com/dotnet/sdk/blob/main/src/BuiltInTools/BrowserRefresh/BlazorHotReload.js.

The #46693 rewrote the invoke as a JSImport and with that we can call directly the async function receiveHotReloadAsync.

With the resolution of this issue we can remove disableDotnet6Compatibility: false from https://github.com/maraf/aspnetcore/blob/99a1d2c0cb39cbddb0e771d76c15fa96cae46261/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts#L347
@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 25, 2023
@maraf
Copy link
Member Author

maraf commented Apr 25, 2023 •
edited
Loading

/cc @MackinnonBuck @pavelsavara

@pavelsavara
Copy link
Member

disableDotnet6Compatibility: false is there also for 3rd party code which uses those global objects.
Let's flip it together with legacy interop when we link it out by default in the next major version (Net9).

@pavelsavara
Copy link
Member

I agree that hotreload should be simplified.

@mkArtakMSFT
Copy link
Contributor

@maraf is this something you plan to take care of?

@mkArtakMSFT mkArtakMSFT added this to the 8.0-preview5 milestone Apr 25, 2023
@mkArtakMSFT
Copy link
Contributor

@maraf based on our current understanding it seems it's ok to leave this to preview5 and nothing will break in preview4 because of this. Can you please confirm this is correct?

@pavelsavara
Copy link
Member

Confirmed, this is not necessary to be fixed in preview4.

This was referenced Apr 28, 2023
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly task
Projects
None yet
Milestone
8.0-preview5
4 participants
@pavelsavara @maraf @MackinnonBuck @mkArtakMSFT