-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Log HTTPs cert info on startup #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This seems like a good thing, thoughts @blowdart ? |
Aside from thumbprint yes (thumbprint is sha1, we don't like sha1) Also add valid from and valid to or maybe the san (or first 5 hosts in the ssn, because those can get big) |
Triage: This would be nice.
|
Thanks for contacting us. |
This is because hosting prints the addresses right? |
Right. #23601 is related, if we have some way of grouping startup logs to make the output nice. |
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
@ldillonel This looks like it's relevant to your cert work. Might be good to look into it. |
Why is using SHA1 for thumbprints a problem here @blowdart ? AIUI, thumbprints aren't used for any security purpose, merely for making it easier to refer to a particular certificate. If it was used for signatures or the like, then sure, but I don't think there's any security issue in using it as an identifier. |
It's a problem because we're trying to eliminate all use of sha1 internally, no matter what it's used for. We have a lot of automated tooling that helps us avoid mistakes and the tooling doesn't understand context. We also have customers who run their own tools and flag of any use of sha1 and then I end up with emails and having to explain the context that no, this isn't a cryptographic use. And if it's used over certificates it makes that explanation so much harder. So it's simpler to eliminate all uses. It's the main reason we have non-cryptographic hash algorithms now. (And in this case it's used for certificate identification which is so close to touching a cryptographic purpose it's not worth the argument). |
Kestrel logs endpoint when the server starts, but doesn't log which certificates were used. Now that Kestrel endpoints and certs can be configured from a file aspnet/KestrelHttpServer#2186, it would be nice to show console info to help users identify if their config was correctly used.
Some ideas:
From store, show friendly name
From store, show subject
From store, include more info like thumbprint
From file
Multiple certs
The text was updated successfully, but these errors were encountered: