Skip to content

Blazor time to first UI regression: blazorwasmbenchmark #45641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pr-benchmarks bot opened this issue Dec 17, 2022 · 9 comments
Closed

Blazor time to first UI regression: blazorwasmbenchmark #45641

pr-benchmarks bot opened this issue Dec 17, 2022 · 9 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Perf perf-regression Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@pr-benchmarks
Copy link

pr-benchmarks bot commented Dec 17, 2022

Scenario Environment Date Old (ms) New (ms) Change Dependencies
blazorwasmbenchmark 12/16/2022 06:53:54 227 242 6.84 % (16) 👎
Changes
NameVersionDiff

PowerBI Dashboard

@sebastienros sebastienros added the area-blazor Includes: Blazor, Razor Components label Jan 18, 2023
@mkArtakMSFT
Copy link
Contributor

@sebastienros when will these be closed? This one is a month old now.

@sebastienros
Copy link
Member

I don't think I should close it unless I recognize the change (infrastructure, false positive, ...). This seems like an actual regression so IMO the product owner should own the decision.

I added the label yesterday (and it will now be set automatically) such that you can triage it more easily.

Do you want to change the workflow?

@MackinnonBuck
Copy link
Member

Looks like the culprit is likely this dependency update PR: #45475.

That PR included some changes to Blazor WASM startup - perhaps those had an impact on startup time?

It should also be noted that, given that multiple dependencies were updated all at once (and this PR switched to the net8.0 runtime as well), it's possible that the root cause lies elsewhere.

/CC @pavelsavara

@pavelsavara
Copy link
Member

That PR included some changes to Blazor WASM startup - perhaps those had an impact on startup time?

probably JS changes are not the problem. Upgrade itself could be.

@lewing do you have more hints ?

@lewing
Copy link
Member

lewing commented Jan 25, 2023

dotnet/runtime@1a37caf...caa0bd5 is over a month of changes from basically the start of .net8 till mid december, it could be so many things.

@lewing
Copy link
Member

lewing commented Jan 25, 2023

what browser+version are these tests running on?

@MackinnonBuck
Copy link
Member

@lewing The tests are running on Chrome 108

@mkArtakMSFT mkArtakMSFT added this to the .NET 8 Planning milestone Jan 30, 2023
@ghost
Copy link

ghost commented Jan 30, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added Priority:1 Work that is critical for the release, but we could probably ship without bug This issue describes a behavior which is not expected - a bug. labels Jan 30, 2023
@lewing
Copy link
Member

lewing commented Apr 13, 2023

These numbers are currently much better than they were I think we can close this

@lewing lewing closed this as completed Apr 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Perf perf-regression Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

5 participants