Use top level statements does not have an accelerator key in display name for Visual Studio

[phenning]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

From https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1576097/

Accelerator key should be displayed for use top level statements (and probably other template defined options as well)

See also, dotnet/templating#4961

Expected Behavior

Some sort of accelerator key should be indicated.

Steps To Reproduce

Repro steps:
Launch VS and open NPD
Choose any web project template and click "Next" to "Additional information"
Click "Alt" on the keyboard
Observe the "Do not use top-level statements" option

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

[TanayParikh]

cc/ @DamianEdwards & @dougbu as this may impact ongoing localization efforts

[dougbu]

I don't see a localization issue here. Added underscores in template.json or ide.host.json files should automatically cause those underscores to be reflected in templatestrings.en.json files (assuming the dev does a local build and includes updated localize/* files in their PR). The next OneLocBuild handback PR should propagate them to the other language files.

[phenning]

@dougbu is correct, worse case is that non-enu would not have the accelerators until the updated language strings files got checked in by OneLocBuild.

[phenning]

A bit greater concern is how dotnet new handles underscores in display names in the help text. I asked that question in the dotnet/templating version of this issue.

[dougbu]

@phenning is it a bug that underscores are duplicated from template.json files (if that's where they first appear) into templatestrings.{lang}.json files as part of the $(UsingToolTemplateLocalizer) processing❔ I suspect underscores that appear only in ide.host.json files will avoid both any dotnet new issues and problematic translations but I'm not sure how accelerators work in a localized VS instance.

/cc @jonfortescue
/fyi @cristianosuzuki77

[phenning]

I'm not sure what you mean, do you mean that a string like "Do not use _top level statements" would added to templatestrings.en.json as "Do not use __toplevel statements"? Have you seen this with other strings? That seems like it would be a bug to me, since I would think we would want the accelerator indicator preserved.

/cc @vlada-shubina

[dougbu]

Sorry s/duplicated/copied/. I was asking if the accelerator indicator should appear anywhere but in ide.jost.json files and whether using it in template.json and the strings files would cause problems.

/fyi existing "translated" accelerator indicators:

• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ItemTemplates/content/ViewImports/.template.config/localize/templatestrings.cs.json#L6
• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ItemTemplates/content/ViewStart/.template.config/localize/templatestrings.cs.json#L5
• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.cs.json#L8
• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.cs.json#L32
• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.cs.json#L8
• https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.cs.json#L15

As far as I can see, these strings aren't visible in the command-line help e.g. dotnet new install viewimports --help doesn't show an option to open the new ViewImports.cshtml file in an editor and dotnet new blazorwasm --help doesn't use the displayName properties referenced above.

[phenning]

Vlada informed me that the CLI does not currently use the displayName property. So it is safe to put the accelerators into the template.json and templatestrings.json files as the displayName.

[jonfortescue]

Accelerators can be loc'd, but under our current loc process they often require manual intervention to ensure we're not breaking our product with duplicate accelerators. There's not much we can do about that without significantly overhauling the loc process. Basically, if using accelerators, make sure to scrutinize the loc PR handbacks.

[vlada-shubina]

According to dotnet/templating#4961 (comment) suggestion we will be using T as accelerator.

[captainsafia]

Closed via #42802.