Skip to content

Consider updating DataAnnotationsMetadataProvider to use NullabilityInfoContext #38774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavkm opened this issue Dec 1, 2021 · 1 comment · Fixed by #39219
Closed

Consider updating DataAnnotationsMetadataProvider to use NullabilityInfoContext #38774

pranavkm opened this issue Dec 1, 2021 · 1 comment · Fixed by #39219
Assignees
Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Dec 1, 2021

DataAnnotationsMetadataProvider currently infers nullability attributes by manually trawling for and reverse engineering the compiler emitted attributes: https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.DataAnnotations/src/DataAnnotationsMetadataProvider.cs#L476-L505. We should update these to use NullabilityInfoContext given that it exists.

@pranavkm pranavkm added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Dec 1, 2021
@rafikiassumani-msft rafikiassumani-msft added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Dec 2, 2021
@rafikiassumani-msft rafikiassumani-msft added this to the .NET 7 Planning milestone Dec 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants