Skip to content

Better error message when SignalR message size limit exceeded #32360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteveSandersonMS opened this issue May 3, 2021 · 2 comments
Closed
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-server Pillar: Dev Experience

Comments

@SteveSandersonMS
Copy link
Member

Currently when you have an event or JS interop call whose payload exceeds the SignalR message size limit, the circuit disconnects (which is correct) but the error message is unhelpful:

Connection disconnected with error 'Error: Server returned an error on close: Connection closed with an error.'

(Source)

As part of #30289 we plan to create convenient new APIs to transmit large amounts of data without exceeding message limits, but it will still be possible to exceed the message size limits if you choose not to use those new APIs.

We should ideally:

  • On startup, detect the configured SignalR max message size
  • Supply this info to the JS side (e.g., in the options we transmit anyway)
  • Have the JS-side code specifically catch cases where you're doing an event or JS interop call that's too big, and fail it before it even gets sent (still causing a circuit disconnect) but with a much clearer message that points to docs

The docs will explain the new APIs that you should use when sending large amounts of data. We will not recommend increasing the SignalR message size, as that isn't a real solution (maybe you still need even bigger payloads later).

@SteveSandersonMS SteveSandersonMS added area-blazor Includes: Blazor, Razor Components feature-blazor-server labels May 3, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label May 4, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, BlazorPlanning Nov 5, 2023
@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-server Pillar: Dev Experience
Projects
None yet
Development

No branches or pull requests

2 participants