Skip to content

Resolve open issues around FS-dependency in source generators #30234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
captainsafia opened this issue Feb 17, 2021 · 1 comment
Closed

Resolve open issues around FS-dependency in source generators #30234

captainsafia opened this issue Feb 17, 2021 · 1 comment
Assignees
Labels
affected-most This issue impacts most of the customers bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-source-generators severity-minor This label is used by an internal tool
Milestone

Comments

@captainsafia
Copy link
Member

The implementation of the RazorSourceGenerator that we created relies on file system interactions in two places:

  • when computing the generated Razor files as part of compilation
  • when reading/writing the tag helper cache during compilation

FS-access for source generators is not recommended so we need to resolve this long term. Some thoughts:

  • We need to determine if tooling relies on the tag helper cache being in the file system. If not, then we can nuke that particular bit of code. If so, we might want to consider alternative ways for generating this cache.
  • Our work to bundle the views with the app assembly should render the generated Razor files unnecessary.
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Feb 17, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@captainsafia captainsafia self-assigned this Feb 18, 2021
@captainsafia captainsafia added affected-most This issue impacts most of the customers severity-minor This label is used by an internal tool labels Feb 19, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Feb 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-most This issue impacts most of the customers bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-source-generators severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

2 participants