Remove nameof use from LoggerMessage.Define calls

[Tratcher]

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.cs

Line 15 in 3a942ff

LoggerMessage.Define<string>(LogLevel.Debug, new EventId(1, nameof(ConnectionStart)), @"Connection id ""{ConnectionId}"" started.");

These names are considered public API and should not be changed even if the thing they're named after changes. As such we don't want to use nameof because the tools would automatically rename them.

Compare to:

aspnetcore/src/SignalR/clients/csharp/Client.Core/src/HubConnection.Log.cs

Line 16 in 49c01ee

LoggerMessage.Define<string, int>(LogLevel.Trace, new EventId(1, "PreparingNonBlockingInvocation"), "Preparing non-blocking invocation of '{Target}', with {ArgumentCount} argument(s).");

[ghost]

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[adrianwright109]

I can take this issue, if you're ok with that?

[adrianwright109]

I have submitted a PR which removes the use of nameof from LoggerMessage.Define calls.