Skip to content

Profile HTTP/2 and identify hotspots #13745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 9 tasks
shirhatti opened this issue Sep 5, 2019 · 7 comments
Closed
2 of 9 tasks

Profile HTTP/2 and identify hotspots #13745

shirhatti opened this issue Sep 5, 2019 · 7 comments
Assignees
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP2 Perf severity-nice-to-have This label is used by an internal tool task
Milestone

Comments

@shirhatti
Copy link
Contributor

shirhatti commented Sep 5, 2019

Scenarios:

  • TechEmpower plaintext but over HTTP/2
  • Basic POST. Request is text/plain string of name. Reply is text/plain "Hello " + name
  • Basic gRPC. See gRPC tutorial
  • Streaming gRPC. The same as the basic gRPC but the server streaming multiple messages
  • Stream per connection vs multiple streams on one connection
  • H2 vs H2C
  • Kestrel and IIS HTTP/2 performance
  • Server streaming

Output:

  • Create new HTTP2 issues with screenshots/traces/numbers from profile
@shirhatti shirhatti added area-servers HTTP2 Epic Groups multiple user stories. Can be grouped under a theme. labels Sep 5, 2019
@shirhatti shirhatti added this to the 5.0.0-preview1 milestone Sep 5, 2019
@JamesNK JamesNK added Perf and removed Epic Groups multiple user stories. Can be grouped under a theme. labels Sep 5, 2019
@JamesNK JamesNK mentioned this issue Sep 5, 2019
7 tasks
@JamesNK JamesNK added the cost: M label Sep 5, 2019
@JamesNK JamesNK mentioned this issue Sep 5, 2019
6 tasks
@davidfowl
Copy link
Member

This is an old benchmark from preview4 #6567

@jkotalik
Copy link
Contributor

@JamesNK is #13752 sufficient for the info covered here?

@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool task labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@BrennanConroy
Copy link
Member

@JamesNK Any remaining work? And is it for Next Sprint or Backlog?

@JamesNK
Copy link
Member

JamesNK commented Feb 5, 2021

Backlog

@JamesNK
Copy link
Member

JamesNK commented Feb 5, 2021

I think there are improvements still to be made to writing frames on busy multiplexed connections but not a priority for 6.0

@ghost
Copy link

ghost commented Feb 5, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@JamesNK
Copy link
Member

JamesNK commented Aug 22, 2022

I'm going to close this. With .NET 7 we've hit the known remaining hotspots: upload flow control, and download concurrency.

In the future, we can have individual issues for future HTTP/2 perf hotspots.

@JamesNK JamesNK closed this as completed Aug 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP2 Perf severity-nice-to-have This label is used by an internal tool task
Projects
None yet
Development

No branches or pull requests

8 participants