Implement IHttpResponseCompletionFeature.CompleteAsync for response compression #11194
Labels
area-middleware
Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Done
This issue has been fixed
enhancement
This issue represents an ask for new feature or an enhancement to an existing one
feature-response-compression
Milestone
Uh oh!
There was an error while loading. Please reload this page.
#11193 added IHttpResponseCompletionFeature.CompleteAsync for gRPC scenarios, allowing the response to be completed without waiting for the request delegate to unwind.
ResponseCompression needs to wrap this feature in order to close and flush the compression buffer. Otherwise the response will be corrupt and an exception will be thrown when the compression middleware tries to flush on unwind.
@anurse recommend for preview7 or 8.
gRPC isn't relying on compression, but someone could add it and break.Nevermind, response compression wouldn't ever interop with gRPC because A) HTTPS and B) Content-Types. We still need to implement this, but gRPC isn't a relevant scenario.The text was updated successfully, but these errors were encountered: