Skip to content

Implement IHttpResponseCompletionFeature.CompleteAsync for response compression #11194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tratcher opened this issue Jun 13, 2019 · 2 comments
Closed
Assignees
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-response-compression

Comments

@Tratcher
Copy link
Member

Tratcher commented Jun 13, 2019

#11193 added IHttpResponseCompletionFeature.CompleteAsync for gRPC scenarios, allowing the response to be completed without waiting for the request delegate to unwind.

ResponseCompression needs to wrap this feature in order to close and flush the compression buffer. Otherwise the response will be corrupt and an exception will be thrown when the compression middleware tries to flush on unwind.

@anurse recommend for preview7 or 8. gRPC isn't relying on compression, but someone could add it and break. Nevermind, response compression wouldn't ever interop with gRPC because A) HTTPS and B) Content-Types. We still need to implement this, but gRPC isn't a relevant scenario.

@Tratcher Tratcher added enhancement This issue represents an ask for new feature or an enhancement to an existing one PRI: 2 - Preferred feature-response-compression labels Jun 13, 2019
@Tratcher Tratcher self-assigned this Jun 13, 2019
@analogrelay analogrelay added this to the Backlog milestone Jul 24, 2019
@analogrelay
Copy link
Contributor

analogrelay commented Jul 24, 2019

As this is labelled 'enhancement', I'm moving to the backlong. @Tratcher if you'd like us to get this done for 3.0, we could put @jkotalik on it :). Seems trivial enough.

@Tratcher
Copy link
Member Author

This will be covered by #12328

@Tratcher Tratcher added the Done This issue has been fixed label Jul 26, 2019
@Tratcher Tratcher modified the milestones: Backlog, 3.0.0-preview8 Jul 26, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-response-compression
Projects
None yet
Development

No branches or pull requests

4 participants