Skip to content

Review pubternal types in SignalR and make them internal or public #10169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
analogrelay opened this issue May 10, 2019 · 5 comments
Closed

Review pubternal types in SignalR and make them internal or public #10169

analogrelay opened this issue May 10, 2019 · 5 comments
Assignees
@mikaelm12
Labels
area-signalr Includes: SignalR clients and servers clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors
Milestone
3.0.0-preview7

Comments

@analogrelay
Copy link
Contributor

Pubternal is so last year. Let's review SignalR pubternal types and make decisions about what we want to make public and if there's anything we want to take internal.
@analogrelay analogrelay added the area-signalr Includes: SignalR clients and servers label May 10, 2019
@analogrelay analogrelay mentioned this issue May 10, 2019
Merged
@halter73
Copy link
Member

@anurse Should we file a similar issue for Kestrel and all the other solutions that still have pubternal types? Or do we want this issue to track that as well?

@halter73
Copy link
Member

Never mind. We merged #8517 already. #8308 is probably what we'd consider the "Epic" for this issue.

@pranavkm pranavkm mentioned this issue May 11, 2019
Closed
15 tasks
@analogrelay analogrelay added this to the 3.0.0-preview7 milestone May 16, 2019
@analogrelay analogrelay added clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors and removed triage-review labels May 16, 2019
@analogrelay
Copy link
Contributor Author

The first work item here is to find them and list them.

@BrennanConroy BrennanConroy mentioned this issue Jun 6, 2019
Merged
@mikaelm12
Copy link
Contributor

mikaelm12 commented Jun 11, 2019 •
edited
Loading

Microsoft.AspNetCore.Http.Connections.Client.Internal (Make these internal)

  • ITransport
  • ITransportFactory
  • LongPollingTransport
  • ServerSentEventsTransport
  • WebsocketsTransport

Microsoft.AspNetCore.Http.Connections.Internal.Transports (Make these internal)

  • IHttpTransport
  • LongPollingTransport
  • ServerSentEventsTransport
  • WebSocketsTransport
    Microsoft.AspNetCore.Http.Connections.Internal
  • ServerSentEventsMessageFormatter

Microsoft.AspNetCore.SignalR.Internal (Make these internal, except...)

  • DefaultHubActivator
  • DefaultHubCallerContext
  • DefaultHubDispatcher
  • DefaultHubProtocolResolver
  • HubCallerClients
  • HubDispatcher (Make this public)
  • HubOptionsSetup
  • HubOptionsSetup
  • HubReflectionHelper
  • TypeBaseEnumerationExtensions

Microsoft.AspNetCore.SignalR.StackExchangeRedis.Internal (Make these internal)

  • GroupAction
  • RedisGroupCommand
  • RedisInvocation
  • RedisProtocol

Edit More Pubternal Types
Microsoft.AspNetCore.Http.Connections.Internal.

  • HttpConnectionContext
  • HttpConnectionDispatcher
  • HttpConnectionManager
  • HttpConnectionStatus

@analogrelay analogrelay added the triage-focus Add this label to flag the issue for focus at triage label Jun 11, 2019
@analogrelay
Copy link
Contributor Author

Nice, let's look at this in triage

@analogrelay analogrelay removed the triage-focus Add this label to flag the issue for focus at triage label Jun 11, 2019
@mikaelm12 mikaelm12 mentioned this issue Jun 12, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikaelm12 mikaelm12

Labels
area-signalr Includes: SignalR clients and servers clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors
Projects
None yet
Milestone
3.0.0-preview7
Development

No branches or pull requests
3 participants
@analogrelay @halter73 @mikaelm12