Skip to content

Commit ed05d7e

Browse files
committed
Addressed feedback from Mackinnon
1 parent 5415283 commit ed05d7e

File tree

3 files changed

+29
-13
lines changed

3 files changed

+29
-13
lines changed

src/Components/Components/src/Binding/ModelBindingContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Microsoft.AspNetCore.Components.Binding;
66
/// <summary>
77
/// The binding context associated with a given model binding operation.
88
/// </summary>
9-
public class ModelBindingContext
9+
public sealed class ModelBindingContext
1010
{
1111
internal ModelBindingContext(string name, string bindingContextId)
1212
{

src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ internal Task DispatchCapturedEvent()
133133

134134
private static string GenerateComponentPath(ComponentState state)
135135
{
136-
// We are generating a path from the root component with te component type names like:
136+
// We are generating a path from the root component with component type names like:
137137
// App > Router > RouteView > LayoutView > Index > PartA
138138
// App > Router > RouteView > LayoutView > MainLayout > NavigationMenu
139139
// To help developers identify when they have multiple forms with the same handler.

src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
EXECUTE_COMPONENTS_E2E_TESTS. At least build the Components E2E tests locally unless SkipTestBuild is set.
66
-->
77
<_BuildAndTest>false</_BuildAndTest>
8-
<_BuildAndTest Condition=" '$(ContinuousIntegrationBuild)' == 'true' AND '$(EXECUTE_COMPONENTS_E2E_TESTS)' == 'true' ">true</_BuildAndTest>
9-
<_BuildAndTest Condition=" '$(ContinuousIntegrationBuild)' != 'true' AND '$(SkipTestBuild)' != 'true' ">true</_BuildAndTest>
8+
<_BuildAndTest
9+
Condition=" '$(ContinuousIntegrationBuild)' == 'true' AND '$(EXECUTE_COMPONENTS_E2E_TESTS)' == 'true' ">true</_BuildAndTest>
10+
<_BuildAndTest
11+
Condition=" '$(ContinuousIntegrationBuild)' != 'true' AND '$(SkipTestBuild)' != 'true' ">true</_BuildAndTest>
1012
<ExcludeFromBuild Condition=" !$(_BuildAndTest) ">true</ExcludeFromBuild>
1113
<SkipTests Condition=" !$(_BuildAndTest) ">true</SkipTests>
1214
</PropertyGroup>
@@ -61,15 +63,29 @@
6163
</ItemGroup>
6264

6365
<ItemGroup Condition="'$(TestTrimmedApps)' == 'true'">
64-
<ProjectReference Include="..\..\benchmarkapps\Wasm.Performance\TestApp\Wasm.Performance.TestApp.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\Wasm.Performance.TestApp\" />
65-
66-
<ProjectReference Include="..\testassets\BasicTestApp\BasicTestApp.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\BasicTestApp\" />
67-
68-
<ProjectReference Include="..\testassets\GlobalizationWasmApp\GlobalizationWasmApp.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\GlobalizationWasmApp\;" />
69-
70-
<ProjectReference Include="..\..\WebAssembly\testassets\StandaloneApp\StandaloneApp.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\StandaloneApp\;" />
71-
72-
<ProjectReference Include="..\..\WebAssembly\testassets\Wasm.Prerendered.Server\Wasm.Prerendered.Server.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\Wasm.Prerendered.Server\;" />
66+
<ProjectReference Include="..\..\benchmarkapps\Wasm.Performance\TestApp\Wasm.Performance.TestApp.csproj"
67+
Targets="Build;Publish"
68+
Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\Wasm.Performance.TestApp\" />
69+
70+
<ProjectReference
71+
Include="..\testassets\BasicTestApp\BasicTestApp.csproj"
72+
Targets="Build;Publish"
73+
Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\BasicTestApp\" />
74+
75+
<ProjectReference
76+
Include="..\testassets\GlobalizationWasmApp\GlobalizationWasmApp.csproj"
77+
Targets="Build;Publish"
78+
Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\GlobalizationWasmApp\;" />
79+
80+
<ProjectReference
81+
Include="..\..\WebAssembly\testassets\StandaloneApp\StandaloneApp.csproj"
82+
Targets="Build;Publish"
83+
Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\StandaloneApp\;" />
84+
85+
<ProjectReference
86+
Include="..\..\WebAssembly\testassets\Wasm.Prerendered.Server\Wasm.Prerendered.Server.csproj"
87+
Targets="Build;Publish"
88+
Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\Wasm.Prerendered.Server\;" />
7389
</ItemGroup>
7490

7591
<!-- Shared testing infrastructure for running E2E tests using selenium -->

0 commit comments

Comments
 (0)