Skip to content

Commit dae72ad

Browse files
committed
Address PR feedback
1 parent e167639 commit dae72ad

File tree

6 files changed

+6
-10
lines changed

6 files changed

+6
-10
lines changed

src/Http/Http.Abstractions/src/Metadata/IResult.cs renamed to src/Http/Http.Abstractions/src/IResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
using System.Threading.Tasks;
55

6-
namespace Microsoft.AspNetCore.Http.Metadata
6+
namespace Microsoft.AspNetCore.Http
77
{
88
/// <summary>
99
/// Defines a contract that represents the result of an HTTP endpoint.

src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*REMOVED*Microsoft.AspNetCore.Routing.RouteValueDictionary.TryAdd(string! key, object! value) -> bool
55
*REMOVED*static Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.UseMiddleware(this Microsoft.AspNetCore.Builder.IApplicationBuilder! app, System.Type! middleware, params object![]! args) -> Microsoft.AspNetCore.Builder.IApplicationBuilder!
66
*REMOVED*static Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.UseMiddleware<TMiddleware>(this Microsoft.AspNetCore.Builder.IApplicationBuilder! app, params object![]! args) -> Microsoft.AspNetCore.Builder.IApplicationBuilder!
7+
Microsoft.AspNetCore.Http.IResult
8+
Microsoft.AspNetCore.Http.IResult.ExecuteAsync(Microsoft.AspNetCore.Http.HttpContext! httpContext) -> System.Threading.Tasks.Task!
79
Microsoft.AspNetCore.Http.Metadata.IFromBodyMetadata
810
Microsoft.AspNetCore.Http.Metadata.IFromBodyMetadata.AllowEmpty.get -> bool
911
Microsoft.AspNetCore.Http.Metadata.IFromFormMetadata
@@ -15,8 +17,6 @@ Microsoft.AspNetCore.Http.Metadata.IFromQueryMetadata.Name.get -> string?
1517
Microsoft.AspNetCore.Http.Metadata.IFromRouteMetadata
1618
Microsoft.AspNetCore.Http.Metadata.IFromRouteMetadata.Name.get -> string?
1719
Microsoft.AspNetCore.Http.Metadata.IFromServiceMetadata
18-
Microsoft.AspNetCore.Http.Metadata.IResult
19-
Microsoft.AspNetCore.Http.Metadata.IResult.ExecuteAsync(Microsoft.AspNetCore.Http.HttpContext! httpContext) -> System.Threading.Tasks.Task!
2020
Microsoft.AspNetCore.Http.Endpoint.Endpoint(Microsoft.AspNetCore.Http.RequestDelegate? requestDelegate, Microsoft.AspNetCore.Http.EndpointMetadataCollection? metadata, string? displayName) -> void
2121
Microsoft.AspNetCore.Http.Endpoint.RequestDelegate.get -> Microsoft.AspNetCore.Http.RequestDelegate?
2222
Microsoft.AspNetCore.Routing.RouteValueDictionary.TryAdd(string! key, object? value) -> bool

src/Http/Routing/src/Internal/MapActionExpressionTreeBuilder.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using System.Reflection;
1212
using System.Threading;
1313
using System.Threading.Tasks;
14-
using Microsoft.AspNetCore.Builder;
1514
using Microsoft.AspNetCore.Http;
1615
using Microsoft.AspNetCore.Http.Metadata;
1716
using Microsoft.Extensions.DependencyInjection;
@@ -320,7 +319,7 @@ public static RequestDelegate BuildRequestDelegate(Delegate action)
320319
private static void LogRequestBodyIOException(HttpContext httpContext, IOException exception)
321320
{
322321
var loggerFactory = httpContext.RequestServices.GetRequiredService<ILoggerFactory>();
323-
var logger = loggerFactory.CreateLogger(typeof(MapActionEndpointRouteBuilderExtensions).FullName!);
322+
var logger = loggerFactory.CreateLogger("Microsoft.AspNetCore.Routing.MapAction");
324323
Log.RequestBodyIOException(logger, exception);
325324
}
326325

src/Http/Routing/test/UnitTests/Internal/MapActionExpressionTreeBuilderTest.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using System.Text.Json;
1212
using System.Threading;
1313
using System.Threading.Tasks;
14-
using Microsoft.AspNetCore.Builder;
1514
using Microsoft.AspNetCore.Http;
1615
using Microsoft.AspNetCore.Http.Features;
1716
using Microsoft.AspNetCore.Http.Metadata;
@@ -257,7 +256,7 @@ public async Task RequestDelegateLogsFromBodyIOExceptionsAsDebug()
257256
{
258257
var invoked = false;
259258

260-
var sink = new TestSink(context => context.LoggerName == typeof(MapActionEndpointRouteBuilderExtensions).FullName);
259+
var sink = new TestSink(context => context.LoggerName == "Microsoft.AspNetCore.Routing.MapAction");
261260
var testLoggerFactory = new TestLoggerFactory(sink, enabled: true);
262261

263262
void TestAction([FromBody] Todo todo)
@@ -321,7 +320,7 @@ public async Task RequestDelegateLogsFromFormIOExceptionsAsDebug()
321320
{
322321
var invoked = false;
323322

324-
var sink = new TestSink(context => context.LoggerName == typeof(MapActionEndpointRouteBuilderExtensions).FullName);
323+
var sink = new TestSink(context => context.LoggerName == "Microsoft.AspNetCore.Routing.MapAction");
325324
var testLoggerFactory = new TestLoggerFactory(sink, enabled: true);
326325

327326
void TestAction([FromForm] int value)

src/Mvc/Mvc.Core/src/JsonResult.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using System.Text.Json;
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Http;
8-
using Microsoft.AspNetCore.Http.Metadata;
98
using Microsoft.AspNetCore.Mvc.Infrastructure;
109
using Microsoft.Extensions.DependencyInjection;
1110

src/Mvc/Mvc.Core/src/StatusCodeResult.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System;
55
using System.Threading.Tasks;
66
using Microsoft.AspNetCore.Http;
7-
using Microsoft.AspNetCore.Http.Metadata;
87
using Microsoft.AspNetCore.Mvc.Infrastructure;
98
using Microsoft.Extensions.DependencyInjection;
109
using Microsoft.Extensions.Logging;

0 commit comments

Comments
 (0)