Skip to content

Commit da7fead

Browse files
authored
Update branding to 6.0.0 Alpha1 (#24983)
* Update branding to 6.0.0 Alpha1 - hold the TFM back at `net5.0` - correct `TargetFrameworkVersion` in FrameworkList.xml; don't use `$(AspNetCoreMajorMinorVersion)` - move `$(DefaultNetCoreTargetFramework)` to eng/Versions.props - avoid repeating value in AfterSolutionBuild.targets and Directory.Build.props files - add new versions to `TemplatePackageInstaller` - update project template test scripts * Update / add 6.0 package versions in test expectations - basically, remove test assumptions that branding == target TFM - `TestData` will need another update once 6.0.0.0 assembly versions arrive from dotnet/runtime * Update `Condition`s on `@(SuppressBaselineReference)` items to 6.0 * Undo some of #24816 - allow sharedFx assemblies in Microsoft.AspNetCore.Components.WebAssembly.DevServer package - see #26448 about reducing this baggage later in 6.0 * Skip IndividualAuth tests on Helix - #26776
1 parent b866b76 commit da7fead

28 files changed

+127
-139
lines changed

Directory.Build.props

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@
8787
<NuspecBasePath>$(MSBuildProjectDirectory)</NuspecBasePath>
8888

8989
<IncludeSymbols>true</IncludeSymbols>
90-
91-
<!--
92-
Also update the DefaultNetCoreTargetFramework defined at src/Razor/test/testassets/Directory.Build.props and
93-
the packages referenced in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj when this changes.
94-
-->
95-
<DefaultNetCoreTargetFramework>net5.0</DefaultNetCoreTargetFramework>
9690
<DefaultNetFxTargetFramework>net461</DefaultNetFxTargetFramework>
9791
</PropertyGroup>
9892

eng/AfterSolutionBuild.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<RepoTasks.RemoveSharedFrameworkDependencies Condition="@(_BuildOutput->Count()) != 0"
1616
Files="@(_BuildOutput)"
1717
FrameworkOnlyPackages="@(AspNetCoreAppReference)"
18-
SharedFrameworkTargetFramework="net$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)" />
18+
SharedFrameworkTargetFramework="$(DefaultNetCoreTargetFramework)" />
1919
</Target>
2020

2121
</Project>

eng/Versions.props

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,17 @@
66
-->
77
<Project>
88
<PropertyGroup Label="Version settings">
9-
<AspNetCoreMajorVersion>5</AspNetCoreMajorVersion>
9+
<AspNetCoreMajorVersion>6</AspNetCoreMajorVersion>
1010
<AspNetCoreMinorVersion>0</AspNetCoreMinorVersion>
1111
<AspNetCorePatchVersion>0</AspNetCorePatchVersion>
12+
<PreReleaseVersionIteration>1</PreReleaseVersionIteration>
1213
<!--
1314
When StabilizePackageVersion is set to 'true', this branch will produce stable outputs for 'Shipping' packages
1415
-->
1516
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion>
1617
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
17-
<PreReleaseVersionLabel>rtm</PreReleaseVersionLabel>
18-
<PreReleaseBrandingLabel>RTM $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
18+
<PreReleaseVersionLabel>alpha</PreReleaseVersionLabel>
19+
<PreReleaseBrandingLabel>Alpha $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
1920
<IncludePreReleaseLabelInPackageVersion>true</IncludePreReleaseLabelInPackageVersion>
2021
<IncludePreReleaseLabelInPackageVersion Condition=" '$(DotNetFinalVersionKind)' == 'release' ">false</IncludePreReleaseLabelInPackageVersion>
2122
<AspNetCoreMajorMinorVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</AspNetCoreMajorMinorVersion>
@@ -38,6 +39,10 @@
3839
<AspNetCoreModuleVersionRevision>$(AspNetCorePatchVersion)</AspNetCoreModuleVersionRevision>
3940
<!-- This is used for error checking to ensure generated code and baselines are up to date when we increment the patch. -->
4041
<PreviousAspNetCoreReleaseVersion Condition=" '$(AspNetCorePatchVersion)' != '0' ">$(AspNetCoreMajorMinorVersion).$([MSBuild]::Subtract($(AspNetCorePatchVersion), 1))</PreviousAspNetCoreReleaseVersion>
42+
<!--
43+
Update the packages referenced in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj when this changes.
44+
-->
45+
<DefaultNetCoreTargetFramework>net5.0</DefaultNetCoreTargetFramework>
4146
</PropertyGroup>
4247
<PropertyGroup Label="Arcade settings">
4348
<!-- Opt-in to Arcade tools for building VSIX projects. -->

src/Components/Components/src/Microsoft.AspNetCore.Components.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<ItemGroup>
2929
<SuppressBaselineReference Include="Microsoft.AspNetCore.Components.Analyzers" InNuspecFile="true" />
3030
<SuppressBaselineReference Include="Microsoft.AspNetCore.Authorization" InNuspecFile="true" />
31-
<SuppressBaselineReference Include="Microsoft.JSInterop" Condition=" '$(AspNetCoreMajorMinorVersion)' == '5.0' " />
31+
<SuppressBaselineReference Include="Microsoft.JSInterop" Condition=" '$(AspNetCoreMajorMinorVersion)' == '6.0' " />
3232
</ItemGroup>
3333

3434
<Target Name="_GetNuspecDependencyPackageVersions">

src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,10 @@
1212
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
1313
<!-- Set this to false because assemblies should not reference this assembly directly, (except for tests, of course). -->
1414
<IsProjectReferenceProvider>false</IsProjectReferenceProvider>
15-
16-
<!--
17-
This project compiles against Microsoft.AspNetCore.App from the SDK.
18-
This ensures that it's packaging output is correct and does not include local artifacts.
19-
-->
20-
<UseAspNetCoreSharedRuntime>true</UseAspNetCoreSharedRuntime>
21-
<DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp>true</DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp>
2215
</PropertyGroup>
2316

2417
<ItemGroup>
25-
<FrameworkReference Include="Microsoft.AspNetCore.App" />
26-
27-
<ProjectReference
28-
Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
29-
PrivateAssets="All"
30-
ReferenceOutputAssembly="false"
31-
SkipGetTargetFrameworkProperties="true" />
32-
18+
<Reference Include="Microsoft.AspNetCore" />
3319
<Reference Include="Microsoft.AspNetCore.Components.WebAssembly.Server" />
3420
<Compile Include="$(SharedSourceRoot)CommandLineUtils\**\*.cs" />
3521
</ItemGroup>
@@ -46,5 +32,4 @@
4632
<NuspecProperty Include="PackageThirdPartyNoticesFile=$(PackageThirdPartyNoticesFile)" />
4733
</ItemGroup>
4834

49-
5035
</Project>

src/Components/WebAssembly/Sdk/testassets/Directory.Build.props

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
<!-- Do not resolve Reference ItemGroup since it has a different semantic meaning in Razor test apps -->
1313
<EnableCustomReferenceResolution>false</EnableCustomReferenceResolution>
1414

15-
<DefaultNetCoreTargetFramework>net5.0</DefaultNetCoreTargetFramework>
16-
1715
<RepoRoot Condition="'$(RepoRoot)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, 'AspNetCore.sln'))\</RepoRoot>
1816

1917
<RazorSdkCurrentVersionProps>$(RepoRoot)src\Razor\Microsoft.NET.Sdk.Razor\src\build\netstandard2.0\Sdk.Razor.CurrentVersion.props</RazorSdkCurrentVersionProps>

src/Framework/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<ItemGroup>
1616
<FrameworkListRootAttributes Include="Name" Value="$(AspNetCoreAppFrameworkBrandName)" />
1717
<FrameworkListRootAttributes Include="TargetFrameworkIdentifier" Value="$(NETCoreAppFrameworkIdentifier)" />
18-
<FrameworkListRootAttributes Include="TargetFrameworkVersion" Value="$(AspNetCoreMajorMinorVersion)" />
18+
<FrameworkListRootAttributes Include="TargetFrameworkVersion" Value="$(DefaultNetCoreTargetFramework.Substring(3))" />
1919
<FrameworkListRootAttributes Include="FrameworkName" Value="$(SharedFxName)" />
2020
</ItemGroup>
2121

src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
<_Parameter1>SharedFxVersion</_Parameter1>
1717
<_Parameter2>$(SharedFxVersion)</_Parameter2>
1818
</AssemblyAttribute>
19+
<AssemblyAttribute Include="Microsoft.AspNetCore.TestData">
20+
<_Parameter1>DefaultNetCoreTargetFramework</_Parameter1>
21+
<_Parameter2>$(DefaultNetCoreTargetFramework)</_Parameter2>
22+
</AssemblyAttribute>
1923
<AssemblyAttribute Include="Microsoft.AspNetCore.TestData">
2024
<_Parameter1>TargetRuntimeIdentifier</_Parameter1>
2125
<_Parameter2>$(TargetRuntimeIdentifier)</_Parameter2>

src/Framework/test/SharedFxTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class SharedFxTests
2727
public SharedFxTests(ITestOutputHelper output)
2828
{
2929
_output = output;
30-
_expectedTfm = "net" + TestData.GetSharedFxVersion().Substring(0, 3);
30+
_expectedTfm = TestData.GetDefaultNetCoreTargetFramework();
3131
_expectedRid = TestData.GetSharedFxRuntimeIdentifier();
3232
_sharedFxRoot = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("ASPNET_RUNTIME_PATH"))
3333
? Path.Combine(TestData.GetTestDataValue("SharedFrameworkLayoutRoot"), "shared", "Microsoft.AspNetCore.App", TestData.GetTestDataValue("RuntimePackageVersion"))
@@ -108,7 +108,7 @@ public void SharedFrameworkContainsValidDepsJson()
108108
{
109109
var depsFilePath = Path.Combine(_sharedFxRoot, "Microsoft.AspNetCore.App.deps.json");
110110

111-
var target = $".NETCoreApp,Version=v{TestData.GetSharedFxVersion().Substring(0, 3)}/{_expectedRid}";
111+
var target = $".NETCoreApp,Version=v{_expectedTfm.Substring(3)}/{_expectedRid}";
112112
var ridPackageId = $"Microsoft.AspNetCore.App.Runtime.{_expectedRid}";
113113
var libraryId = $"{ridPackageId}/{TestData.GetTestDataValue("RuntimePackageVersion")}";
114114

src/Framework/test/TargetingPackTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public TargetingPackTests(ITestOutputHelper output)
2929
{
3030
_output = output;
3131
_expectedRid = TestData.GetSharedFxRuntimeIdentifier();
32-
_targetingPackTfm = "net" + TestData.GetSharedFxVersion().Substring(0, 3);
32+
_targetingPackTfm = TestData.GetDefaultNetCoreTargetFramework();
3333
var root = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("helix")) ?
3434
TestData.GetTestDataValue("TargetingPackLayoutRoot") :
3535
Environment.GetEnvironmentVariable("DOTNET_ROOT");

0 commit comments

Comments
 (0)