PR feedback

halter73 · halter73 · commit d5ebf767ee04 · 2019-06-27T13:52:52.000-07:00
diff --git a/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs b/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
@@ -449,9 +449,9 @@ private async Task StartAsyncCore(CancellationToken cancellationToken)
             Log.Started(_logger);
         }
 
-        private Task CloseAsync(ConnectionContext connection)
+        private ValueTask CloseAsync(ConnectionContext connection)
         {
-            return connection.DisposeAsync().AsTask();
+            return connection.DisposeAsync();
         }
 
         // This method does both Dispose and Start, the 'disposing' flag indicates which.

Original file line number	Diff line number	Diff line change
`@@ -449,9 +449,9 @@ private async Task StartAsyncCore(CancellationToken cancellationToken)`
`449`	`449`	`Log.Started(_logger);`
`450`	`450`	`}`
`451`	`451`
`452`		`- private Task CloseAsync(ConnectionContext connection)`
	`452`	`+ private ValueTask CloseAsync(ConnectionContext connection)`
`453`	`453`	`{`
`454`		`- return connection.DisposeAsync().AsTask();`
	`454`	`+ return connection.DisposeAsync();`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`// This method does both Dispose and Start, the 'disposing' flag indicates which.`